Minutes of the code management group meeting 2018-09-05
From UKCA
Revision as of 09:13, 29 August 2018 by Nla27 (talk | contribs) (Created page with "Code management group minutes ==Teleconference Details== '''Wednesday 5th September 2018, 10am - 12noon BST''' * '''UK Landline:''' +44 (0)1223 761376 (x61376 from an i...")
Teleconference Details
Wednesday 5th September 2018, 10am - 12noon BST
- UK Landline: +44 (0)1223 761376 (x61376 from an internal University of Cambridge phone)
- Participant PIN: 323180
Present
Met Office:
Cambridge:
Leeds:
Reading:
Lancaster:
Edinburgh:
UEA:
NIWA:
CSIRO:
Apologies:
Actions from this meeting
One-off actions
Standing actions
- (ongoing - standing item) CMG to monitor list of bugs and circulate between group for owners.
- (ongoing - standing item) At CMG future meetings there should be included an appendix listing the open bugs. If a ticket is included it is not an open bug (as the owner of ticket is person doing lodging).
- (ongoing - standing item) ALL with access to keep monitoring ukca_bugs email list.
- (ongoing - standing item) ALL to think about if code changes will change KGO and let systems team know in good time, and remember to include the UKCA & SC0138 keywords to all UKCA tickets. This should be a standard part of our working practice. Note also the required keywords.
- (ongoing - standing item) ALL to note, review, and remove obsolete/redundant code
- (ongoing - standing item) ALL closed ticket owners to produce a summary of their change for the UKCA newsletter
- (ongoing - standing item) Code Owner to produce draft newsletter for CMG to approve.
Minutes
Actions from the Last Meeting (LA)
Minutes of the code management group meeting 2018-04-17
One-off actions
- (ongoing) MY to check GLOMAP-mode code and report any missing bug fixes on the bugfixes page.
- (ongoing) LA to liaise with MY.
- (ongoing) LA to migrate PUMA UM tickets to MOSRS - see table below.
- (ongoing) LA to open tickets for all changes that still require a ticket.
- (ongoing) FOC to recommend at next Exec meeting a policy of allowing only CMG to (certify and) distribute any UKCA configurations for science purpose.
- (ongoing) MD to collate all UKCA parameters into
ukca_constants
in advance of removing duplicates already available in the UM and circulate details. - (new) LA to put
C_SPECIES
definitions in the Redundant Code table (short-term), and switch to useM_SPECIES
instead. Talk with JH about AQUM tests and requirements. - (ongoing) AJH to scope out reducing repetition of mode definitions in GLOMAP.
- (ongoing) MD/LA to talk about releases offline, and set up free-running and nudged GA7.1+StratTrop TS2000ish timeslice, with instructions to make it transient.
- (ongoing) LA to create Wiki page on UKCA website for users to add details of configurations and input files.
- (ongoing) ALL to review output from vn11.0 release candidate(s).
- (ongoing) MG to progress ticket um:#3909 after doing further tests.
- (new) ALL to feedback to AJH by 2nd July regarding UKCA Rose panel changes
- (new) FOC to ask Paul Agnew to send AQUM representative to CMG
- (new) FOC to circulate doodle poll for further emissions discussion to CMG for all to fill-in. That meeting to report to CMG
- (new) MR to discuss with KP implications for GLOMAP.
- (new) LA to contact FOC, AH, MK, KP, ATA, Ken Carslaw, Philip Stier regarding taking the proposal for a separate code repository forward.
- (new) FOC to see what action can be taken from MASS, then put out an email for POCs from institutes.
- (new) LA to do doodle poll for weeks 1-2 of September 2018.
Standing actions
- (ongoing - standing item) CMG to monitor list of bugs and circulate between group for owners.
- (ongoing - standing item) At CMG future meetings there should be included an appendix listing the open bugs. If a ticket is included it is not an open bug (as the owner of ticket is person doing lodging).
- (ongoing - standing item) ALL with access to keep monitoring ukca_bugs email list.
- (ongoing - standing item) ALL to think about if code changes will change KGO and let systems team know in good time, and remember to include the UKCA & SC0138 keywords to all UKCA tickets. This should be a standard part of our working practice. Note also the required keywords.
- (ongoing - standing item) ALL to note, review, and remove obsolete/redundant code
- (ongoing - standing item) ALL closed ticket owners to produce a summary of their change for the UKCA newsletter
- (ongoing - standing item) Code Owner to produce draft newsletter for CMG to approve.
Bugs/Bugfixes (LA)
Open Bugs
# | Description | Ticket | Owner | Status/ Updates | Comments from previous meeting | Comments from this meeting | |
---|---|---|---|---|---|---|---|
35 | Error in labelling: Surface resistance <--> stomatal resistance ? | MOSRS #1409 | Fiona O'Connor | Leave open. Garry Hayman started work in offline JULES | Leave open | ||
74 | Bug in ukca_tropopause with definition of PV tropopause | #1283 | Fiona O'Connor | FOC to update comments. Scope has been extend. | Leave open | ||
75 | Bug in STE fluxes | #1367 | Fiona O'Connor | Leave open. Still not sure if ENDGame related or not. | Leave open | ||
87 | Possible issues with YSTORE in UKCA_CHEMISTRY_CTL. | UM#3245 | Colin Johnson/ Luke Abraham |
leave open. | Leave open | ||
96 | Output drydiam diagnostics where l_ukca_arg_act but not l_ukca_radaer | UM#3962 | Unknown | The beginnings of a solution are found in vn11.0_ukca_drydiam_activate_wo_radaer. | AJH to take ownership - may be affected by reorganisation. | ||
98 | Incorrect usage of npft integer when npft == 9 OR 13 |
UM#4157 | Alan J Hewitt (& Garry Hayman) | To be lodged at vn11.2 Follow-on ticket to remove temporary logical (l_fix_ukca_h2dd_x) UM#4245 |
Redundant Code (LA)
Code for deletion
PLEASE REMEMBER TO EDIT THE ORIGINAL REDUNDANT CODE TABLE AND NOT THIS PAGE
# | Description | Ticket | Remarks | Status | Timeframe | Owner | Comments from this meeting |
---|---|---|---|---|---|---|---|
2 | Old dry deposition scheme | #2356 | None | PROPOSED | Medium-term | Nick Savage | |
4 | ukca_strat_update.F90 - relax_ozone | #1505 | None | PROPOSED | Medium-term | Luke Abraham | |
5 | Backward Euler Standard Tropospheric Chemistry | #1507 | None | PROPOSED | Medium-term | Fiona O'Connor | |
6 | Wet oxidation of SO2 in GLOMAP | None | None | PROPOSED | Medium-term | Colin Johnson | |
7 | Updraft velocity | #3668 | Proposed in December 2017 | PROPOSED | Medium-term | Alan J Hewitt | |
8 | All backward Euler chemistry schemes | None | Note that this is only for the “hard-coded” BE schemes. Quite a lot of work would be involved, but good as a longer-term aim. Note that problems for AQUM would need to be addressed first. | PROPOSED | Long-term | Luke Abraham | |
9 | Deprecated UKCA netcdf attribute options | #2513 | 'emission_type', string type attributes no longer recommeneded. Need some time for most new code to adopt these. Still used in AQUM files. | DEPRECATED | Medium-term | Nick Savage | AQUM are addressing the files. |
10 | ASAD families chemistry | None | Families chemistry has not been used for many years (since at least UM6.1. It is likely that it no longer works if turned on, and it complicates the code making other developments harder | DEPRECATED | Short-term | Luke Abraham | |
11 | Dry deposition 9 PFT option | None | The 13 PFT option has been adopted for UKESM1. The 9 PFT option is possibly not being used at all. Proposed in June 2018. |
PROPOSED | Long-term | Alan J Hewitt | |
12 | Remove explicit C_SPECIES constants and calculate these from M_SPECIES and the mass of air |
None | Will have wide-ranging rose-stem KGO breakages | PROPOSED | Short-term | Luke Abraham | |
13 | Remove temporary logical l_fix_nacl_density Introduced at UM:#2405 by Colin Johnson |
UM:#3490 | Requires AMIP testing an a GMED ticket Could be accepted to GA9 |
PROPOSED | Medium-term | None | |
14 | Remove temporary logical l_fix_nh4no3_equilibrium Introduced at UM:#646 by Carlos Ordonez |
None | Requires AMIP testing an a GMED ticket Could be accepted to GA9 |
PROPOSED | Medium-term | None | |
15 | Remove temporary logical l_fix_ukca_impscav Introduced at UM:#1421 |
UM:#4145 | Approval being sought for GA series (likely GA9) GMED:#402 |
PROPOSED | Medium-term | Alan J Hewitt | |
16 | Remove temporary logical l_fix_improve_drydep Introduced at UM:#1250 |
UM:#3997 | Approval being sought for GA series (likely GA9) GMED:#393 |
PROPOSED | Medium-term | Alan J Hewitt | |
17 | Remove temporary logical l_fix_ukca_h2dd_x Introduced at UM:#4157 |
UM:#4245 | Approval being sought for GA series (likely GA9) GMED:#410 |
PROPOSED | Medium-term | Alan J Hewitt |
There were questions regarding what GA & AQUM use in terms of numbers of PFTS.
UKCA Release Job (LA/MD)
Targets for vn11.2 (and beyond) (LA)
PLEASE REMEMBER TO INCLUDE THE KEYWORDS: UKCA & SC0138
Tickets targeting vn11.2
# | Description |
---|---|
#2689 | Enable coupling of GLOMAP-MODE Aerosol to FAST-JX photolysis. |
#3127 | Investigate KGO differences in um_n48_ukca_eg app using GNU on the Cray |
#3292 | Consolidate constant variables used by UKCA |
#3769 | Time updating for glomap climatology |
#3959 | RO2-Permutation Chemistry |
#3962 | Output dry diameter diagnostic in niche case where l_ukca_arg_act but not l_ukca_radaer |
#3970 | Tidy the UKCA gui panel |
#4001 | Magic numbers in ukca_setup_chem_mod.F90 |
#4020 | Improved calculation of ozone dry deposition to ocean - surface resistance term |
#4024 | Triggering of i_ukca_dms_flux by l_sulpc_so2 |
#4032 | Addition of new diagnostics for the wet and dry deposition flux of oxidised nitrogen |
Tickets targeting vn11.3
# | Description |
---|---|
#3997 | Retire temporary logical l_fix_improve_drydep |