Difference between revisions of "Minutes of the code management group meeting 2021-02-26"
Line 71: | Line 71: | ||
!style="text-align:top;rowspan=2";|Comments from this meeting |
!style="text-align:top;rowspan=2";|Comments from this meeting |
||
|- |
|- |
||
− | | 35 || Error in labelling: Surface resistance <--> stomatal resistance ? || [https://code.metoffice.gov.uk/trac/um/ticket/1409 UM:#1409] || '''Fiona O'Connor''' || Leave open. Garry Hayman started work in offline JULES. <br/> Still ongoing. JM found bug in SO2 deposition, where there is an inconsistency when changing tiles. Making progress. <br/> Leave open. GH gave update, has done a lot of work. Concerned it might not be bit-reproducable, but could be solvable. Encouraging to lodge existing. Resistances done as metadata. Not clear as to timescales.<br/> FOC to encourage Garry Hayman to start lodging JULES code piecemeal. <br/> LA to email GH, cc JM <br/> JM to email GH || '''Comments from this meeting''' |
+ | | 35 || Error in labelling: Surface resistance <--> stomatal resistance ? || [https://code.metoffice.gov.uk/trac/um/ticket/1409 UM:#1409] || '''Fiona O'Connor''' || Leave open. Garry Hayman started work in offline JULES. <br/> Still ongoing. JM found bug in SO2 deposition, where there is an inconsistency when changing tiles. Making progress. <br/> Leave open. GH gave update, has done a lot of work. Concerned it might not be bit-reproducable, but could be solvable. Encouraging to lodge existing. Resistances done as metadata. Not clear as to timescales.<br/> FOC to encourage Garry Hayman to start lodging JULES code piecemeal. <br/> LA to email GH, cc JM <br/> JM to email GH || '''Comments from this meeting''' |
|- |
|- |
||
− | | 101 || Errors in reaction rates and diagnostics || [https://code.metoffice.gov.uk/trac/um/ticket/4466 UM:#4466] || '''Luke Abraham / Scott Archer-Nicolls''' || There is a need to conserve science config for UKESM1, so changes need to be on a flag.<br/>Colin has been looking at DMSO, as this is not currently used in StratTrop but is in Offline.<br/>Might be able to merge the rate with CEJ changes, but best to leave the diagnostic issues as a separate change. <br/> LA, JM, CEJ, SAN to discuss offline and keep GM in loop.<br/>Use versioning system. Talk about further offline. <br/> Keep ongoing. <br/> LA to do with #103 <br/> Do for vn11.6. Quite a large ticket. <br/> Hope to progress for vn11.6 <br/> Bump for vn11.7 <br/> LA may be able to progress. Versioning has been done separately. Another issue was added to this recently, to do with formation of H2O - may have an impact <br/> Some CRI fixes needed too. May not be able to progress for vn11.7 || '''Comments from this meeting''' |
+ | | 101 || Errors in reaction rates and diagnostics || [https://code.metoffice.gov.uk/trac/um/ticket/4466 UM:#4466] || '''Luke Abraham / Scott Archer-Nicolls''' || There is a need to conserve science config for UKESM1, so changes need to be on a flag.<br/>Colin has been looking at DMSO, as this is not currently used in StratTrop but is in Offline.<br/>Might be able to merge the rate with CEJ changes, but best to leave the diagnostic issues as a separate change. <br/> LA, JM, CEJ, SAN to discuss offline and keep GM in loop.<br/>Use versioning system. Talk about further offline. <br/> Keep ongoing. <br/> LA to do with #103 <br/> Do for vn11.6. Quite a large ticket. <br/> Hope to progress for vn11.6 <br/> Bump for vn11.7 <br/> LA may be able to progress. Versioning has been done separately. Another issue was added to this recently, to do with formation of H2O - may have an impact <br/> Some CRI fixes needed too. May not be able to progress for vn11.7 || '''Comments from this meeting''' |
|- |
|- |
||
| 103 || Incorrect indexing of tmprc array: ASAD_SPIMPMJP || [https://code.metoffice.gov.uk/trac/um/ticket/4562 UM:#4562] || '''Luke Abraham''' || Breaks KGO - affects solver convergence. In practice doesn’t make a huge difference, but should go into vn11.4, but does change KGO. UKESM1 - small change might be OK - get in touch for advice - might be able to test with UKESM1 AMIP only. Check with Oliver Wild <br/> Could be rolled-up with #101 <br/> LA to do with #101 <br/> Bump for vn11.7 || '''Comments from this meeting''' |
| 103 || Incorrect indexing of tmprc array: ASAD_SPIMPMJP || [https://code.metoffice.gov.uk/trac/um/ticket/4562 UM:#4562] || '''Luke Abraham''' || Breaks KGO - affects solver convergence. In practice doesn’t make a huge difference, but should go into vn11.4, but does change KGO. UKESM1 - small change might be OK - get in touch for advice - might be able to test with UKESM1 AMIP only. Check with Oliver Wild <br/> Could be rolled-up with #101 <br/> LA to do with #101 <br/> Bump for vn11.7 || '''Comments from this meeting''' |
Revision as of 16:10, 25 February 2021
Teleconference Details
Friday 26th February 2021, 10.00am - 11.30am GMT
Meeting via Zoom - details have been emailed
Met Office: AJH
Cambridge:
Leeds:
Reading:
Lancaster:
Edinburgh:
UEA:
NIWA:
CSIRO:
Apologies:
Actions from this meeting
- (new) LA to send round Doodle Poll for next meeting during UM11.9-11.10 cycle.
Minutes
Actions from the Last Meeting (LA)
- (ongoing) LA to put
C_SPECIES
definitions in the Redundant Code table (short-term), and switch to useM_SPECIES
instead. Talk with JH about AQUM tests and requirements. Note that there will be problems with exoplanets and >100km top configs where M_air not constant. LA to make a branch and progress for vn11.6. - (ongoing) ALL to consider Monsoon users MASS data plan and feedback to FOC. Please also include suggestions for local points of contact. Met Office contacts mostly identified, FOC/AH will start scouting for contacts at the Institutes.
- (ongoing) LA to contact AS/AJH and ask how best to proceed with removing the depreciated NetCDF attribute options. Do after GA8 is released as still required for GA7.
- (ongoing) GM (supported by KP/MY/AH) has made a table on UKCA wiki documenting GLOMAP versions. ALL to read, GM & others to update table.
- (ongoing) LA to add N48 Linux and update EXP test No ticket found for N48-Linux, but _exp app is updated regularly.
- (ongoing) LA to contact AJH/GM offline regarding coupling StratTrop to GLOMAP-CLIM
- (ongoing) LA to contact GF about bug #109 (Bug in dry deposition of CH4 for 13/17/27 tiles)
- (new) AJH to follow up with LA regarding depreciated NetCDF attributes given that GA8 is now released
- (new) JH, AJH, MD, LA, FOC to discuss usability of the Old (non-interactive) Dry deposition scheme : (a) For standalone model without JULES (b) for NWP-type configs which do not run with either of the hardwired 9,17,27,.. tiles
- (new) AJH to contact MR, and possibly involve JH to look at variable (temporary?) copying in GLOMAP and any memory implications for LFRic/ Stand-alone
- (new) JH, NC, LA, FOC, OM (and possibly others) to discuss the need for data from 2-D Cambridge model as well as other top-boundary options for tropospheric configurations
- (new) LA to send round Doodle Poll for next meeting during UM11.8-11.9 cycle.
Standing actions
- (ongoing - standing item) CMG to monitor list of bugs and circulate between group for owners.
- (ongoing - standing item) At CMG future meetings there should be included an appendix listing the open bugs. If a ticket is included it is not an open bug (as the owner of ticket is person doing lodging).
- (ongoing - standing item) ALL with access to keep monitoring ukca_bugs email list.
- (ongoing - standing item) ALL to think about if code changes will change KGO and let systems team know in good time, and remember to include the UKCA keywords to all UKCA tickets. This should be a standard part of our working practice. Note also the required keywords.
- (ongoing - standing item) ALL to note, review, and remove obsolete/redundant code
- (ongoing - standing item) ALL closed ticket owners to produce a summary of their change for the UKCA newsletter for special occasions, e.g. to coincide with Composition-Climate Meeting.
- (ongoing - standing item) Code Owner to produce draft newsletter for CMG to approve.
- (ongoing - standing item) ALL to consider other rose-stem tests that could be included
- (ongoing - standing item) ALL to email LA with suggestions for next set of tutorials
Bugs/Bugfixes (LA)
Open Bugs
# | Description | Ticket | Owner | Comments | Comments from this meeting |
---|---|---|---|---|---|
35 | Error in labelling: Surface resistance <--> stomatal resistance ? | UM:#1409 | Fiona O'Connor | Leave open. Garry Hayman started work in offline JULES. Still ongoing. JM found bug in SO2 deposition, where there is an inconsistency when changing tiles. Making progress. Leave open. GH gave update, has done a lot of work. Concerned it might not be bit-reproducable, but could be solvable. Encouraging to lodge existing. Resistances done as metadata. Not clear as to timescales. FOC to encourage Garry Hayman to start lodging JULES code piecemeal. LA to email GH, cc JM JM to email GH |
Comments from this meeting |
101 | Errors in reaction rates and diagnostics | UM:#4466 | Luke Abraham / Scott Archer-Nicolls | There is a need to conserve science config for UKESM1, so changes need to be on a flag. Colin has been looking at DMSO, as this is not currently used in StratTrop but is in Offline. Might be able to merge the rate with CEJ changes, but best to leave the diagnostic issues as a separate change. LA, JM, CEJ, SAN to discuss offline and keep GM in loop. Use versioning system. Talk about further offline. Keep ongoing. LA to do with #103 Do for vn11.6. Quite a large ticket. Hope to progress for vn11.6 Bump for vn11.7 LA may be able to progress. Versioning has been done separately. Another issue was added to this recently, to do with formation of H2O - may have an impact Some CRI fixes needed too. May not be able to progress for vn11.7 |
Comments from this meeting |
103 | Incorrect indexing of tmprc array: ASAD_SPIMPMJP | UM:#4562 | Luke Abraham | Breaks KGO - affects solver convergence. In practice doesn’t make a huge difference, but should go into vn11.4, but does change KGO. UKESM1 - small change might be OK - get in touch for advice - might be able to test with UKESM1 AMIP only. Check with Oliver Wild Could be rolled-up with #101 LA to do with #101 Bump for vn11.7 |
Comments from this meeting |
108 | Incorrect stash processing of GLOMAP load*, conc* and plume_scav diagnostics | UM:#4909 | Mohit Dalvi | To be Lodged after 10.6 Do after CMIP6 runs are finished (after Jan 2020) Timeline still on track Bump for vn11.7 May be OK to lodge for vn11.7, but correction is hard-wired in postprocessing scripts. JM to check whether a later version is needed Bump to a later version |
Comments from this meeting |
109 | Bug in dry deposition of CH4 for 13/17/27 tiles | UM:#4913 | Gerd Folberth | To be Lodged after 10.6 Gerd noted unusual CH4 output in CMIP6 runs. May need a rose stem test for H2 and CH4 drdydep code lodged at UM:#4157 Makes a huge difference to CH4. Needs testing. AJH or GF will do during vn11.4, progress for vn11.6. May need UKESM1 approval. Code is difficult to understand. AJH thinks GarryH is aware of this problem. LA to ask GF to add more details GF has emailed. LA to update wiki pages (see below) Only impacts emission driven runs. LA to check with Gerd about this issue |
Comments from this meeting |
110 | UKCA solar-cycle routine does not pass NRUN-CRUN test | UM:#4828 | Luke Abraham | To be Lodged after 11.5 Have a solution. Solution is a bit tricky to check the logic correctly. Currently testing. May not make vn11.7. |
Comments from this meeting |
119 | Incorrect calculation for gridbox area - only affects GLOMAP-mode diagnostics | um:#5506 | Calculation of volume appears correct, but area is not. This calculation is missing the factor fv_cos_theta_latitude so will not cause area to tend towards zero at the poles. It also seems to use an unnecessary approximation to the latitude difference (based on sinv_latitude ) which may break down at high latitudes. The calculation should perhaps be consistent with subsequent volume calculation but without the delta_r factor. This will likely only affect diagnostics calculated in ukca_emiss_diags_mode , where it is used to convert from kg/m2/s to mol/gridbox/s, although it is also printed out in ukca_aero_ctl . JH spotted. Just diagnostic affected. LA to open a ticket. cc JM, NC LA to update with MOSRS ticket |
Comments from this meeting | |
124 | H2 and N2 cannot be set for RCP and WMOA1 scenario routines | UM:#5620 | Mohit Dalvi | Values are hard-wired in the code and cannot be changed without a branch | Comments from this meeting |
125 | Technical/ Rose-stem : ignore-missing flag applied to all Strattrop/CRIstat rose stem tests (instead of just NRUN-CRUN ones). | UM:#5752 | Mohit Dalvi | This is likely to have missed differences in the number of output fields under subsequent changes | Comments from this meeting |
126 | Fast-JX: Double counting of earth-radius in calculation of spherical mass-weighting factors. (Routine fast-jx_sphere) | UM:#5760 | Comments from this meeting | ||
127 | GET_EMDIAG_STASH: Return value from function can remain unset | None yet | Affects all NCDF emiss versions. No value expected for aerosol emissions, but variable remains unset. |
Comments from this meeting | |
128 | Bug in UKCA stratospheric chemistry diagnostics | Comments from this meeting | |||
129 | Warning messages in ukca_radaer_lut_in | Comments from this meeting | |||
130 | Bug in aerosol dry deposition when using 27 surface types in JULES | Comments from this meeting | |||
131 | Invalid surface roughness input to aerosol dry deposition over land | Comments from this meeting |
Redundant Code (LA)
Code for deletion
PLEASE REMEMBER TO EDIT THE ORIGINAL REDUNDANT CODE TABLE AND NOT THIS PAGE
# | Description | Ticket | Remarks | Status | Timeframe | Owner | Comments from previous meetings | Comments from this meeting |
---|---|---|---|---|---|---|---|---|
2 | Old dry deposition scheme | UM:#2356 | None | PROPOSED | Medium-term | Nick Savage | Possibly useful for stand-alone, NWP-type | |
4 | ukca_strat_update.F90 - relax_ozone | UM:#1505 | None | PROPOSED | Medium-term | Luke Abraham | ||
5 | Backward Euler Standard Tropospheric Chemistry | UM:#1507 | None | PROPOSED | Medium-term | Fiona O'Connor | ||
6 | Wet oxidation of SO2 in GLOMAP | UM:#4475 | None | PROPOSED | Medium-term | Colin Johnson | JM to look at this re: UKESM1 c.f. offline GLOMAP. JM to take ownership. Still needed for CTM. Relevance for standalone code and later coupling to CTM. |
|
7 | Updraft velocity - l_conv_tke | UM:#3668 | Proposed in December 2017. Approval being sought for GA series (likely GA8). | PROPOSED | Medium-term | Alan J Hewitt / Ian Boutle | ||
8 | All backward Euler chemistry schemes | None | Note that this is only for the “hard-coded” BE schemes. Quite a lot of work would be involved, but good as a longer-term aim. Note that problems for AQUM would need to be addressed first. | PROPOSED | Long-term | Luke Abraham | ||
9 | Deprecated UKCA netcdf attribute options | UM:#2513 | 'emission_type', string type attributes no longer recommeneded. Need some time for most new code to adopt these. Still used in AQUM files. | DEPRECATED | Medium-term | Nick Savage | AQUM are addressing the files. Have gone from operational jobs, have ticket to remove from rose-stem. LN to document. These have been removed from AQUM. AQUM work has been done. From AS: In the ancil ticket linked from #2513 (https://code.metoffice.gov.uk/trac/ancil/ticket/782) it says that GA7 depends on the old format files, and as far as I know this is still true. In the 3-step timeline suggested, we haven't reached step 2 unfortunately. That ticket was about ensuring GA8 did not use the old attributes. I believe that GA8 is due for release in the next few months (it has been a very long time coming), so UM vn11.5 may be the last version at which GA7 is supported. Do you mind waiting a bit longer? |
AJH to follow-up with LA |
10 | ASAD families chemistry | None | Families chemistry has not been used for many years (since at least UM6.1. It is likely that it no longer works if turned on, and it complicates the code making other developments harder | DEPRECATED | Short-term | Luke Abraham | ||
11 | Dry deposition 9 PFT option | None | The 13 PFT option has been adopted for UKESM1. The 9 PFT option is possibly not being used at all. Proposed in June 2018. |
PROPOSED | Long-term | Alan J Hewitt | ||
12 | Remove explicit C_SPECIES constants and calculate these from M_SPECIES and the mass of air |
None | Will have wide-ranging rose-stem KGO breakages | PROPOSED | Short-term | Luke Abraham | ||
13 | Remove temporary logical l_fix_nacl_density Introduced at UM:#2405 |
UM:#3490 | Requires AMIP testing and a GMED ticket Could be accepted to GA9 |
PROPOSED | Medium-term | Jane Mulcahy | See JM GMED action | |
15 | Remove temporary logical l_fix_ukca_impscav Introduced at UM:#1421 |
UM:#4145 | Approval being sought for GA series (likely GA9) GMED:#402 |
PROPOSED | Medium-term | Alan J Hewitt | See JM GMED action | |
16 | Remove temporary logical l_fix_improve_drydep Introduced at UM:#1250 |
UM:#3997 | Approval being sought for GA series (likely GA9) GMED:#393 |
PROPOSED | Medium-term | Alan J Hewitt | See JM GMED action | |
17 | Remove temporary logical l_fix_ukca_h2dd_x Introduced at UM:#4157 |
UM:#4245 | Approval being sought for GA series (likely GA9) GMED:#410 |
PROPOSED | Medium-term | Alan J Hewitt | See JM GMED action | |
18 | Remove temporary logical l_fix_neg_pvol_wat Introduced at UM:#4383 |
UM:#4416 | Approval being sought for GA series (likely GA9) GMED:#421 |
PROPOSED | Medium-term | Alan J Hewitt | ||
21 | Remove code behind L_use_stratclim from ukca_fastjx_mod Introduced prior to MOSRS |
UM:#4854 | This could either be properly included via a namelist or removed from the UM | PROPOSED | Medium-term | Alan J Hewitt | LA contact OW about progressing FastJX-RADAER work Ties in with API work. MD/NC to take a look, can be removed. Do as part of API. Relevant person take ownership as part of API work NC to take ownership as part of his work |
|
22 | Remove temporary logical l_fix_ukca_input_meoh_emiss Introduced at UM:#3031 |
UM:#4848 | Approval being sought for GA series (likely GA9) GMED:#461 |
PROPOSED | Medium-term | Mohit Dalvi | ||
24 | Remove ability to use of Cambridge 2D model data from ukca_stratf.F90 | PROPOSED | Neal Carr | Need to confirm from wider community for possible tropospheric configs and other choices for top-bdy |
Note point 24 to remove the use of the Cambridge 2D files from the over-writing code.
Update on UKCA API redesign
Please see the document UKCA_API_design_proposal_v5.pdf for the latest API design.
=== Progress with Priorities (LA) === No change
The current priorities are:
# | Description | Owner |
---|---|---|
1 | UKCA API | John Hemmings |
2 | Review UKCA tests to cover all requirements | Luke Abraham / Mohit Dalvi |
3 | Updates/fixes to GLOMAP routines | |
4 | Standalone UKCA configurations | Luke Abraham |
5 | Emissions flexibility | Mohit Dalvi |
6 | Separare UKCA repository | Luke Abraham |
7 | Non-API LFRic work, e.g. I/O, diagnostics etc. | |
8 | RADAER optimisation | |
9 | FastJX-GLOMAP coupling | |
10 | Cloud-J | |
11 | Fixes for chemistry rates and ASAD (bugs #101 & #103) | Luke Abraham |
12 | Rc fixes for water (bug #104) | UKESM Core Team |
13 | CH4 deposition fixes (bug #109) | Gerd Folberth |
14 | UKCA STASHmaster PP-codes | Luke Abraham |
15 | Removal of redundant code | ALL |
16 | GLOMAP-CLIM API refresh | Alan Hewitt |
17 | N48L85 configuration | |
18 | ACTIVATE optimisation |
UM11.8 Tickets
See here for UM vn11.8 tickets on MOSRS.
PLEASE REMEMBER TO USE THE UKCA KEYWORD FOR ALL UKCA CHANGES
NOTE: New requirement for LFric testing
of all changes under src/atmosphere (MD)
PLEASE ADD YOUR UKCA TICKETS TO GROUP TICKET um:#5771
REMEMBER TO "BUMP" TICKETS TO A LATER VERSION (OR "HOPEFULLY") IF IT WILL NOT MAKE THE VN11.7 DEADLINE OF 25TH SEPTEMBER 2020
AOB/DNM (LA)
Round (virtual) Table of current activities, plans'
Activity | |
Alan | GLOMAP-CLIM optimisation for NWP |
Catherine | Sulphur cycle asssement in UKESM1 |
Marc | Bi-cubic remapping (Snr-Jnr) in the hybrid model |
Mark | New person at Leeds/CEMAC to optimise Chemistry solver |
Mohit | API-related refactoring, bugfixes for UM11.8 |
Neal | Assessing performance of Column-based solver vs levelwise |
Olaf | Evaluating CMIP6 runs and IPCC contributions |
Florent | Mainly NAME-related but plans to assess Strattrop for AQ forecasting |
Nicolas | Simplified GLOMAP model (sol/insol) for coupling to CASIM/ wider application |
John | API work - UM module variables via interface |