Difference between revisions of "Minutes of the code management group meeting 2020-09-11"

Line 45: Line 45:
# (Done) LA to send round Doodle Poll for the first 2 weeks of July.
# (Done) LA to send round Doodle Poll for the first 2 weeks of July.
# (new) AJH to follow up with LA regarding depreciated NetCDF attributes given that GA8 is now released
# (new) AJH to follow up with LA regarding depreciated NetCDF attributes given that GA8 is now released
# (new) JH, AJH, MD, LA, FOC to discuss usability of the ''Old'' (non-interactive) Dry deposition scheme : (a) For standalone model without JULES (b) for NWP-type configs which do not have run with either of 9,17,27,.. tiles
# (new) AJH to contact MR, and possibly involve JH to look at variable (temporary?) copying in GLOMAP and any memory implications for LFRic/ Stand-alone
# (new) LA to send round Doodle Poll for next meeting during UM11.8-11.9 cycle.
# (new) LA to send round Doodle Poll for next meeting during UM11.8-11.9 cycle.

Revision as of 13:15, 11 September 2020

Code management group minutes

Teleconference Details

Friday 11th September 2020, 9.30am - 11.30am GMT

Meeting via Zoom - details have been emailed

Met Office: AJH, CH, FM, JH, MG, MS, MD, NC


Leeds: MR

Reading: NB






Apologies: LA, FOC, JM

Actions from this meeting


Actions from the Last Meeting (LA)

  1. (ongoing) LA to put C_SPECIES definitions in the Redundant Code table (short-term), and switch to use M_SPECIES instead. Talk with JH about AQUM tests and requirements. Note that there will be problems with exoplanets and >100km top configs where M_air not constant. LA to make a branch and progress for vn11.6. Keep Open
  2. (ongoing) ALL to consider Monsoon users MASS data plan and feedback to FOC. Please also include suggestions for local points of contact. AH/FOC to assign people following feedback. Met Office contacts mostly identified, will start scouting for contacts at the Institutes. Keep Open
  3. (ongoing) LA to contact AS/AJH and ask how best to proceed with removing the depreciated NetCDF attribute options. Do after GA8 is released as still required for GA7. Keep Open
  4. (Done) JH to update API document and ask for further feedback on this when completed
  5. (ongoing) GM (supported by KP/MY/AH) to make table on UKCA wiki documenting this. LA to email. See GLOMAP versions. LA to email GM. GM has circulated a document, Keep Open till members have a read and table is updated.
  6. (ongoing) LA to add N48 Linux and update EXP test No ticket found for N48-Linux, but _exp app is updated regularly -Keep Open
  7. (ongoing) LA to contact AJH/GM offline regarding coupling StratTrop to GLOMAP-CLIM Keep Open
  8. (Done) DG to progress fix for bug #114. LA to check original email for details & update table. LA contact DG offline #5233 lodged
  9. (ongoing) LA to contact GF about bug #109 (Bug in dry deposition of CH4 for 13/17/27 tiles) Keep open
  10. (Done) LA to update MOSRS links in Bugfixes table and include HG's bug Bug #123 Added
  11. (Done) LA to send round Doodle Poll for the first 2 weeks of July.
  12. (new) AJH to follow up with LA regarding depreciated NetCDF attributes given that GA8 is now released
  13. (new) JH, AJH, MD, LA, FOC to discuss usability of the Old (non-interactive) Dry deposition scheme : (a) For standalone model without JULES (b) for NWP-type configs which do not have run with either of 9,17,27,.. tiles
  14. (new) AJH to contact MR, and possibly involve JH to look at variable (temporary?) copying in GLOMAP and any memory implications for LFRic/ Stand-alone
  15. (new) LA to send round Doodle Poll for next meeting during UM11.8-11.9 cycle.

Standing actions

  1. (ongoing - standing item) CMG to monitor list of bugs and circulate between group for owners.
  2. (ongoing - standing item) At CMG future meetings there should be included an appendix listing the open bugs. If a ticket is included it is not an open bug (as the owner of ticket is person doing lodging).
  3. (ongoing - standing item) ALL with access to keep monitoring ukca_bugs email list.
  4. (ongoing - standing item) ALL to think about if code changes will change KGO and let systems team know in good time, and remember to include the UKCA keywords to all UKCA tickets. This should be a standard part of our working practice. Note also the required keywords.
  5. (ongoing - standing item) ALL to note, review, and remove obsolete/redundant code
  6. (ongoing - standing item) ALL closed ticket owners to produce a summary of their change for the UKCA newsletter for special occasions, e.g. to coincide with Composition-Climate Meeting.
  7. (ongoing - standing item) Code Owner to produce draft newsletter for CMG to approve.
  8. (ongoing - standing item) ALL to consider other rose-stem tests that could be included
  9. (ongoing - standing item) ALL to email LA with suggestions for next set of tutorials

Bugs/Bugfixes (LA)

Open Bugs

# Description Ticket Owner Comments Comments from this meeting
35 Error in labelling: Surface resistance <--> stomatal resistance ? UM:#1409 Fiona O'Connor Leave open. Garry Hayman started work in offline JULES.
Still ongoing. JM found bug in SO2 deposition, where there is an inconsistency when changing tiles. Making progress.
Leave open. GH gave update, has done a lot of work. Concerned it might not be bit-reproducable, but could be solvable. Encouraging to lodge existing. Resistances done as metadata. Not clear as to timescales.
FOC to encourage Garry Hayman to start lodging JULES code piecemeal.
LA to email GH, cc JM
JM to email GH
GH adding improvements via UM:#5751
101 Errors in reaction rates and diagnostics UM:#4466 Luke Abraham / Scott Archer-Nicolls There is a need to conserve science config for UKESM1, so changes need to be on a flag.
Colin has been looking at DMSO, as this is not currently used in StratTrop but is in Offline.
Might be able to merge the rate with CEJ changes, but best to leave the diagnostic issues as a separate change.
LA, JM, CEJ, SAN to discuss offline and keep GM in loop.
Use versioning system. Talk about further offline.
Keep ongoing.
LA to do with #103
Do for vn11.6. Quite a large ticket.
Hope to progress for vn11.6
Bump for vn11.7
LA may be able to progress. Versioning has been done separately. Another issue was added to this recently, to do with formation of H2O - may have an impact
Some CRI fixes needed too. May not be able to progress for vn11.7
Some of the fixes have been incorporated in UM:#5057
103 Incorrect indexing of tmprc array: ASAD_SPIMPMJP UM:#4562 Luke Abraham Breaks KGO - affects solver convergence. In practice doesn’t make a huge difference, but should go into vn11.4, but does change KGO. UKESM1 - small change might be OK - get in touch for advice - might be able to test with UKESM1 AMIP only. Check with Oliver Wild
Could be rolled-up with #101
LA to do with #101
Bump for vn11.7
Being progressed for UMvn11.8
108 Incorrect stash processing of GLOMAP load*, conc* and plume_scav diagnostics UM:#4909 Mohit Dalvi To be Lodged after 10.6
Do after CMIP6 runs are finished (after Jan 2020)
Timeline still on track
Bump for vn11.7
May be OK to lodge for vn11.7, but correction is hard-wired in postprocessing scripts. JM to check whether a later version is needed
Bump to a later version
Progressing for vn11.8
109 Bug in dry deposition of CH4 for 13/17/27 tiles UM:#4913 Gerd Folberth To be Lodged after 10.6
Gerd noted unusual CH4 output in CMIP6 runs.
May need a rose stem test for H2 and CH4 drdydep code lodged at UM:#4157
Makes a huge difference to CH4. Needs testing. AJH or GF will do during vn11.4, progress for vn11.6. May need UKESM1 approval.
Code is difficult to understand. AJH thinks GarryH is aware of this problem.
LA to ask GF to add more details
GF has emailed. LA to update wiki pages (see below)
Only impacts emission driven runs.
LA to check with Gerd about this issue
110 UKCA solar-cycle routine does not pass NRUN-CRUN test UM:#4828 Luke Abraham To be Lodged after 11.5
Have a solution.
Solution is a bit tricky to check the logic correctly.
Currently testing. May not make vn11.7.
Will not make UMvn11.7 - need to analyse runs to understand what is going on
119 Incorrect calculation for gridbox area - only affects GLOMAP-mode diagnostics um:#5506 Calculation of volume appears correct, but area is not. This calculation is missing the factor fv_cos_theta_latitude so will not cause area to tend towards zero at the poles. It also seems to use an unnecessary approximation to the latitude difference (based on sinv_latitude) which may break down at high latitudes. The calculation should perhaps be consistent with subsequent volume calculation but without the delta_r factor. This will likely only affect diagnostics calculated in ukca_emiss_diags_mode, where it is used to convert from kg/m2/s to mol/gridbox/s, although it is also printed out in ukca_aero_ctl.
JH spotted. Just diagnostic affected.
LA to open a ticket. cc JM, NC
LA to update with MOSRS ticket
No owner yet
124 H2 and N2 cannot be set for RCP and WMOA1 scenario routines UM:#5620 Mohit Dalvi Values are hard-wired in the code and cannot be changed without a branch Will be handled at UM11.8
125 Technical/ Rose-stem : ignore-missing flag applied to all Strattrop/CRIstat rose stem tests (instead of just NRUN-CRUN ones). UM:#5752 Mohit Dalvi This is likely to have missed differences in the number of output fields under subsequent changes Progressing for UM11.8
126 Fast-JX: Double counting of earth-radius in calculation of spherical mass-weighting factors. (Routine fast-jx_sphere) UM:#5760 Impact on AQUM, UKCA and UKESM1 being assessed, may need to be lodged with a switch.
127 GET_EMDIAG_STASH: Return value from function can remain unset None yet Affects all NCDF emiss versions.
No value expected for aerosol emissions, but variable remains unset.
No ticket yet. Most likely to be merged with API emission changes.

Redundant Code (LA)

Code for deletion


# Description Ticket Remarks Status Timeframe Owner Comments from previous meetings Comments from this meeting
2 Old dry deposition scheme UM:#2356 None PROPOSED Medium-term Nick Savage
4 ukca_strat_update.F90 - relax_ozone UM:#1505 None PROPOSED Medium-term Luke Abraham
5 Backward Euler Standard Tropospheric Chemistry UM:#1507 None PROPOSED Medium-term Fiona O'Connor
6 Wet oxidation of SO2 in GLOMAP UM:#4475 None PROPOSED Medium-term Colin Johnson JM to look at this re: UKESM1 c.f. offline GLOMAP. JM to take ownership.
Still needed for CTM. Relevance for standalone code and later coupling to CTM.
7 Updraft velocity - l_conv_tke UM:#3668 Proposed in December 2017. Approval being sought for GA series (likely GA8). PROPOSED Medium-term Alan J Hewitt / Ian Boutle
8 All backward Euler chemistry schemes None Note that this is only for the “hard-coded” BE schemes. Quite a lot of work would be involved, but good as a longer-term aim. Note that problems for AQUM would need to be addressed first. PROPOSED Long-term Luke Abraham
9 Deprecated UKCA netcdf attribute options UM:#2513 'emission_type', string type attributes no longer recommeneded. Need some time for most new code to adopt these. Still used in AQUM files. DEPRECATED Medium-term Nick Savage AQUM are addressing the files. Have gone from operational jobs, have ticket to remove from rose-stem. LN to document. These have been removed from AQUM.
AQUM work has been done.
From AS: In the ancil ticket linked from #2513 (https://code.metoffice.gov.uk/trac/ancil/ticket/782) it says that GA7 depends on the old format files, and as far as I know this is still true. In the 3-step timeline suggested, we haven't reached step 2 unfortunately. That ticket was about ensuring GA8 did not use the old attributes. I believe that GA8 is due for release in the next few months (it has been a very long time coming), so UM vn11.5 may be the last version at which GA7 is supported. Do you mind waiting a bit longer?
10 ASAD families chemistry None Families chemistry has not been used for many years (since at least UM6.1. It is likely that it no longer works if turned on, and it complicates the code making other developments harder DEPRECATED Short-term Luke Abraham
11 Dry deposition 9 PFT option None The 13 PFT option has been adopted for UKESM1.
The 9 PFT option is possibly not being used at all.
Proposed in June 2018.
PROPOSED Long-term Alan J Hewitt
12 Remove explicit C_SPECIES constants and calculate these from M_SPECIES and the mass of air None Will have wide-ranging rose-stem KGO breakages PROPOSED Short-term Luke Abraham
13 Remove temporary logical l_fix_nacl_density
Introduced at UM:#2405
UM:#3490 Requires AMIP testing and a GMED ticket
Could be accepted to GA9
PROPOSED Medium-term Jane Mulcahy See JM GMED action
15 Remove temporary logical l_fix_ukca_impscav
Introduced at UM:#1421
UM:#4145 Approval being sought for GA series (likely GA9)
PROPOSED Medium-term Alan J Hewitt See JM GMED action
16 Remove temporary logical l_fix_improve_drydep
Introduced at UM:#1250
UM:#3997 Approval being sought for GA series (likely GA9)
PROPOSED Medium-term Alan J Hewitt See JM GMED action
17 Remove temporary logical l_fix_ukca_h2dd_x
Introduced at UM:#4157
UM:#4245 Approval being sought for GA series (likely GA9)
PROPOSED Medium-term Alan J Hewitt See JM GMED action
18 Remove temporary logical l_fix_neg_pvol_wat
Introduced at UM:#4383
UM:#4416 Approval being sought for GA series (likely GA9)
PROPOSED Medium-term Alan J Hewitt
21 Remove code behind L_use_stratclim from ukca_fastjx_mod
Introduced prior to MOSRS
UM:#4854 This could either be properly included via a namelist or removed from the UM PROPOSED Medium-term Alan J Hewitt LA contact OW about progressing FastJX-RADAER work
Ties in with API work. MD/NC to take a look, can be removed. Do as part of API.
Relevant person take ownership as part of API work
NC to take ownership as part of his work
22 Remove temporary logical l_fix_ukca_input_meoh_emiss
Introduced at UM:#3031
UM:#4848 Approval being sought for GA series (likely GA9)
PROPOSED Medium-term Mohit Dalvi
24 Remove ability to use of Cambridge 2D model data from ukca_stratf.F90 PROPOSED Neal Carr

Note point 24 to remove the use of the Cambridge 2D files from the over-writing code.

Update on UKCA API redesign

Please see the document UKCA_API_design_proposal_v5.pdf for the latest API design.

Progress with Priorities (LA)

The current priorities are:

# Description Owner
1 UKCA API John Hemmings
2 Review UKCA tests to cover all requirements Luke Abraham / Mohit Dalvi
3 Updates/fixes to GLOMAP routines
4 Standalone UKCA configurations Luke Abraham
5 Emissions flexibility Mohit Dalvi
6 Separare UKCA repository Luke Abraham
7 Non-API LFRic work, e.g. I/O, diagnostics etc.
8 RADAER optimisation
9 FastJX-GLOMAP coupling
10 Cloud-J
11 Fixes for chemistry rates and ASAD (bugs #101 & #103) Luke Abraham
12 Rc fixes for water (bug #104) UKESM Core Team
13 CH4 deposition fixes (bug #109) Gerd Folberth
14 UKCA STASHmaster PP-codes Luke Abraham
15 Removal of redundant code ALL
16 GLOMAP-CLIM API refresh Alan Hewitt
17 N48L85 configuration
18 ACTIVATE optimisation

UM11.8 Tickets

See here for UM vn11.8 tickets on MOSRS.


NOTE: New requirement for LFric testing of all changes under src/atmosphere (MD)




Date of next meeting (LA)