Minutes of the code management group meeting 2019-01-25
From UKCA
Teleconference Details
Friday 25th January 2019, 10am - 11.30am GMT
- UK Landline: +44 (0)1223 761376 (x61376 from an internal University of Cambridge phone)
- Participant PIN:
Present
Met Office:
Cambridge:
Leeds:
Reading:
Lancaster:
Edinburgh:
UEA:
NIWA:
CSIRO:
Apologies:
Actions from this meeting
One-off actions
Standing actions
- (ongoing - standing item) CMG to monitor list of bugs and circulate between group for owners.
- (ongoing - standing item) At CMG future meetings there should be included an appendix listing the open bugs. If a ticket is included it is not an open bug (as the owner of ticket is person doing lodging).
- (ongoing - standing item) ALL with access to keep monitoring ukca_bugs email list.
- (ongoing - standing item) ALL to think about if code changes will change KGO and let systems team know in good time, and remember to include the UKCA & SC0138 keywords to all UKCA tickets. This should be a standard part of our working practice. Note also the required keywords.
- (ongoing - standing item) ALL to note, review, and remove obsolete/redundant code
- (ongoing - standing item) ALL closed ticket owners to produce a summary of their change for the UKCA newsletter
- (ongoing - standing item) Code Owner to produce draft newsletter for CMG to approve.
Minutes
Actions from the Last Meeting (LA)
Minutes of the code management group meeting 2018-11-12
One-off actions
- (ongoing) MY to check GLOMAP-mode code and report any missing bug fixes on the bugfixes page.
- (new) GM/MY to arrange telecon with LA when MY starts.
- (ongoing) LA to migrate PUMA UM tickets to MOSRS - see table below.
- (ongoing) LA to open tickets for all changes that still require a ticket.
- (ongoing) FOC to recommend at next Exec meeting a policy of allowing only CMG to (certify and) distribute any UKCA configurations for science purpose.
- (ongoing) MD to collate all UKCA parameters into
ukca_constants
in advance of removing duplicates already available in the UM and circulate details. - (ongoing) LA to put
C_SPECIES
definitions in the Redundant Code table (short-term), and switch to useM_SPECIES
instead. Talk with JH about AQUM tests and requirements. Note that there will be problems with exoplanets and >100km top configs where M_air not constant. LA to make a branch and progress for vn11.3. - (ongoing) AJH to open ticket and assign to himself regarding loops over imode+n and imode-n UM:#4284. Currently code is inflexible when adding modes. AJH to discuss with GM offline.
- (ongoing) LA to make instructions as to make UM11.0 release job transient.
- (ongoing) NLA/MD make script for perpetual nudging (symbolic linking to existing files).
- (ongoing) LA to create Wiki page on UKCA website for users to add details of configurations and input files.
- (ongoing) MR to discuss with KP implications for GLOMAP in regards to a separate UKCA repository
- (new) LA to forward NERC proposal to Leeds.
- (ongoing) NLA to contact CEJ (cc JM) about trace-gas convective plume scavenging and how this will be impacted (or impact) the repository work
- (ongoing) FOC to see what action can be taken from MASS, then put out an email for POCs from institutes. FOC/AH/MD to develop a strategy on MASS for discussion at next CMG
- (ongoing) JM to take make a UM ticket for redundant code item #6 (Wet oxidation of SO2 in GLOMAP). Keep GM/MY in the loop.
- (ongoing) JM to do a catch-call ticket for GMED
- (ongoing) LN to l_fix_nh4no3_equilibrium in rose-stem and jobs and remove if necessary.
- (new) JM to open ticket and new bug for SO2 deposition.
- (new) LA, JM, CEJ, SAN to discuss rate fixes offline and keep GM in loop.
- (new) LA to contact AS and ask how best to proceed with removing the depreciated NetCDF attribute options.
- (new) MD to back-port STE fixes to UM11.0 suite.
- (new) MD/LA to make up vn11.1 and vn11.2 configs similar to TS2000 and send-off 20-year AMIP runs to produce standard evaluation suite plots.
- (new) LA to take ownership of ticket um:#4397(GA7 NR Offline test).
- (new) LA to send round Doodle poll for middle of January.
Standing actions
- (ongoing - standing item) CMG to monitor list of bugs and circulate between group for owners.
- (ongoing - standing item) At CMG future meetings there should be included an appendix listing the open bugs. If a ticket is included it is not an open bug (as the owner of ticket is person doing lodging).
- (ongoing - standing item) ALL with access to keep monitoring ukca_bugs email list.
- (ongoing - standing item) ALL to think about if code changes will change KGO and let systems team know in good time, and remember to include the UKCA & SC0138 keywords to all UKCA tickets. This should be a standard part of our working practice. Note also the required keywords.
- (ongoing - standing item) ALL to note, review, and remove obsolete/redundant code
- (ongoing - standing item) ALL closed ticket owners to produce a summary of their change for the UKCA newsletter
- (ongoing - standing item) Code Owner to produce draft newsletter for CMG to approve.
Bugs/Bugfixes (LA)
Open Bugs
# | Description | Ticket | Owner | Status/ Updates | Comments from previous meetings | Comments from this meeting |
---|---|---|---|---|---|---|
35 | Error in labelling: Surface resistance <--> stomatal resistance ? | UM:#1409 | Fiona O'Connor | Leave open. Garry Hayman started work in offline JULES. Still ongoing. JM found bug in SO2 deposition, where there is an inconsistency when changing tiles. |
||
87 | Possible issues with YSTORE in UKCA_CHEMISTRY_CTL. This may mean than there is no H2SO4 because of this, with impacts on GLOMAP aerosols. Need to also select the correct products in chemistry_ctl. Combination of two different bugs - see r61958_vn10.8_cos_mmr_value_so2_2 | UM:#3245 | Luke Abraham | Leave open. NLA to have another look. MS may have changed things with OMP changes. | ||
96 | Output drydiam diagnostics where l_ukca_arg_act but not l_ukca_radaer | UM:#3962 | Alan J Hewitt | The beginnings of a solution are found in vn11.0_ukca_drydiam_activate_wo_radaer. | Leave open. AJH to take ownership - may be affected by reorganisation. This just limits options. Leave until code is reorganised. | |
101 | Errors in reaction rates and diagnostics | UM:#4466 | Luke Abraham / Scott Archer-Nicolls | There is a need to conserve science config for UKESM1, so changes need to be on a flag. Colin has been looking at DMSO, as this is not currently used in StratTrop but is in Offline. Might be able to merge the rate with CEJ changes, but best to leave the diagnostic issues as a separate change. LA, JM, CEJ, SAN to discuss offline and keep GM in loop. |
||
103 | Incorrect indexing of tmprc array: ASAD_SPIMPMJP | UM:#4562 | ||||
104 | Incorrect value for Rc for SO_2 deposition to open water |
Redundant Code (LA)
Code for deletion
PLEASE REMEMBER TO EDIT THE ORIGINAL REDUNDANT CODE TABLE AND NOT THIS PAGE
# | Description | Ticket | Remarks | Status | Timeframe | Owner | Comments from previous meetings | Comments from this meeting |
---|---|---|---|---|---|---|---|---|
2 | Old dry deposition scheme | UM:#2356 | None | PROPOSED | Medium-term | Nick Savage | ||
4 | ukca_strat_update.F90 - relax_ozone | UM:#1505 | None | PROPOSED | Medium-term | Luke Abraham | ||
5 | Backward Euler Standard Tropospheric Chemistry | UM:#1507 | None | PROPOSED | Medium-term | Fiona O'Connor | ||
6 | Wet oxidation of SO2 in GLOMAP | None | None | PROPOSED | Medium-term | Colin Johnson | JM to look at this re: UKESM1 c.f. offline GLOMAP. JM to take ownership. | |
7 | Updraft velocity - l_conv_tke | UM:#3668 | Proposed in December 2017. Approval being sought for GA series (likely GA8). | PROPOSED | Medium-term | Alan J Hewitt / Ian Boutle | ||
8 | All backward Euler chemistry schemes | None | Note that this is only for the “hard-coded” BE schemes. Quite a lot of work would be involved, but good as a longer-term aim. Note that problems for AQUM would need to be addressed first. | PROPOSED | Long-term | Luke Abraham | ||
9 | Deprecated UKCA netcdf attribute options | UM:#2513 | 'emission_type', string type attributes no longer recommeneded. Need some time for most new code to adopt these. Still used in AQUM files. | DEPRECATED | Medium-term | Nick Savage | AQUM are addressing the files. Have gone from operational jobs, have ticket to remove from rose-stem. LN to document. | These have been removed from AQUM. Action: LA to contact AS and ask how best to proceed. |
10 | ASAD families chemistry | None | Families chemistry has not been used for many years (since at least UM6.1. It is likely that it no longer works if turned on, and it complicates the code making other developments harder | DEPRECATED | Short-term | Luke Abraham | ||
11 | Dry deposition 9 PFT option | None | The 13 PFT option has been adopted for UKESM1. The 9 PFT option is possibly not being used at all. Proposed in June 2018. |
PROPOSED | Long-term | Alan J Hewitt | ||
12 | Remove explicit C_SPECIES constants and calculate these from M_SPECIES and the mass of air |
None | Will have wide-ranging rose-stem KGO breakages | PROPOSED | Short-term | Luke Abraham | ||
13 | Remove temporary logical l_fix_nacl_density Introduced at UM:#2405 |
UM:#3490 | Requires AMIP testing and a GMED ticket Could be accepted to GA9 |
PROPOSED | Medium-term | Jane Mulcahy | See JM GMED action | |
14 | Remove temporary logical l_fix_nh4no3_equilibrium Introduced at UM:#646 |
UM:#4382 | Already accepted to GA9/AQUM/MOGREPS/rose-stem Logical l_fix_nh4no3_equilibrium just needs removing. |
PROPOSED | Medium-term | Pedro Molina-Jimenez | See LN temporary logical action | |
15 | Remove temporary logical l_fix_ukca_impscav Introduced at UM:#1421 |
UM:#4145 | Approval being sought for GA series (likely GA9) GMED:#402 |
PROPOSED | Medium-term | Alan J Hewitt | See JM GMED action | |
16 | Remove temporary logical l_fix_improve_drydep Introduced at UM:#1250 |
UM:#3997 | Approval being sought for GA series (likely GA9) GMED:#393 |
PROPOSED | Medium-term | Alan J Hewitt | See JM GMED action | |
17 | Remove temporary logical l_fix_ukca_h2dd_x Introduced at UM:#4157 |
UM:#4245 | Approval being sought for GA series (likely GA9) GMED:#410 |
PROPOSED | Medium-term | Alan J Hewitt | See JM GMED action | |
18 | Remove temporary logical l_fix_neg_pvol_wat Introduced at UM:#4383 |
UM:#4416 | Approval being sought for GA series (likely GA9) GMED:#421 |
PROPOSED | Medium-term | Alan J Hewitt | ||
19 | Remove MODULEs/SUBROUTINEs/FUNCTIONs within UKCA not called within the UM: SUBROUTINE asad_dealloc_chemdiag FUNCTION cd_findspeciesloc SUBROUTINE asad_lin_diagnostic MODULE asad_emissn_mod and SUBROUTINE asad_emissn FUNCTION prcount MODULE asad_inemit_mod and SUBROUTINE asad_inemit MODULE asad_inhet_mod and SUBROUTINE asad_inhet MODULE asad_inphot_mod and SUBROUTINE asad_inphot SUBROUTINE asad_mod_final MODULE asad_ycn_mod and SUBROUTINE asad_ycn MODULE quanto1d_mod and SUBROUTINE quanto1d SUBROUTINE activmkpdf MODULE ukca_fixedsb_mod and SUBROUTINE ukca_fixedsb SUBROUTINE deallocate_radaer_struct SUBROUTINE ukca_relax_ozone |
UM:#4512 | Not called within UM Need to decide whether any should be kept vn11.2_remove_redundant_code |
DEPRECATED | Short-term | Alan J Hewitt |
UKCA Release Job (LA/MD)
Targets for vn11.3 (and beyond) (LA)
See details of the 29th October UM Developers and Owner's Group.
PLEASE REMEMBER TO:
- INCLUDE THE KEYWORDS: UKCA & SC0138.
- ASSIGN THE TICKET AFTER ITS CREATION. NO TICKETS SHOULD BE LEFT AS NEW.
Tickets targeting vn11.3
UM vn11.3 code review submission deadline is 8th Feb 2019. SOCRATES/JULES/GCOM/CASIM/FFPP/KGO by 1st Feb 2019.
# | Description |
---|---|
UM:#2689 | Enable coupling of GLOMAP-MODE Aerosol to FAST-JX photolysis. |
UM:#3127 | Investigate KGO differences in um_n48_ukca_eg app using GNU on the Cray |
UM:#3292 | Consolidate constant variables used by UKCA |
UM:#3367 | Removing transport of peroxy radical tracers in Strattrop (CHeST) |
UM:#3779 | Improvements to the inline comments in ukca_option_mod |
UM:#3959 | RO2-Permutation Chemistry |
UM:#3997 | Retire temporary logical l_fix_improve_drydep |
UM:#4001 | Magic numbers in ukca_setup_chem_mod.F90 |
UM:#4020 | Improved calculation of ozone dry deposition to ocean - surface resistance term |
UM:#4024 | Triggering of i_ukca_dms_flux by l_sulpc_so2 |
UM:#4131 | Enable use of ASAD Backward-Euler solver with UKCA offline oxidants chemistry |
UM:#4145 | Retire temporary logical l_fix_ukca_impscav |
UM:#4201 | Verify use of qsmin in UKCA plume scavenging diagnostics |
UM:#4221 | Optimisation of GLOMAP_CLIM |
UM:#4231 | Adding Common Representatives Intermediate (CRI) mechanism |
UM:#4245 | Retire temporary logical l_fix_ukca_h2dd_x |
UM:#4288 | Extend GLOMAP_CLIM rose stem testing to new compilers e.g. ifort & gfortran |
UM:#4357 | Replace glomap_clim_n48.nc in rose-stem/app/um_n48_glomap_clim (& n96) |
UM:#4375 | Implement cache-blocking loop in UKCA to optimise the chemistry solver |
UM:#4383 | Calculation of wts() masswaterkg() mdwat() pvol_wat() |
UM:#4397 | Rose stem test for i_ukca_chem=54 |
Use of PP codes in UKCA STASHmaster_A entries
We have been asked to look at retiring PP codes if this is possible. This should be able to be achieved by setting them to 0 in the STASHmaster_A if we do not make use of them.