Minutes of the code management group meeting 2018-11-12

Code management group minutes

Teleconference Details

Monday 12th November 2018, 10am - 11.30am GMT

• UK Landline: +44 (0)1223 761376 (x61376 from an internal University of Cambridge phone)
• Participant PIN: 232764

Present

Met Office:

Cambridge:

Leeds:

Reading:

Lancaster:

Edinburgh:

UEA:

NIWA:

CSIRO:

Apologies:

Actions from this meeting

Standing actions

1. (ongoing - standing item) CMG to monitor list of bugs and circulate between group for owners.
2. (ongoing - standing item) At CMG future meetings there should be included an appendix listing the open bugs. If a ticket is included it is not an open bug (as the owner of ticket is person doing lodging).
3. (ongoing - standing item) ALL with access to keep monitoring ukca_bugs email list.
4. (ongoing - standing item) ALL to think about if code changes will change KGO and let systems team know in good time, and remember to include the UKCA & SC0138 keywords to all UKCA tickets. This should be a standard part of our working practice. Note also the required keywords.
5. (ongoing - standing item) ALL to note, review, and remove obsolete/redundant code
6. (ongoing - standing item) ALL closed ticket owners to produce a summary of their change for the UKCA newsletter
7. (ongoing - standing item) Code Owner to produce draft newsletter for CMG to approve.

Minutes

Actions from the Last Meeting (LA)

Minutes of the code management group meeting 2018-09-05

One-off actions

1. (ongoing) MY to check GLOMAP-mode code and report any missing bug fixes on the bugfixes page.
2. (ongoing) LA to liaise with MY, and to chase MY and GM as to when this would be done.
3. (ongoing) LA to migrate PUMA UM tickets to MOSRS - see table below.
4. (ongoing) LA to open tickets for all changes that still require a ticket.
5. (ongoing) FOC to recommend at next Exec meeting a policy of allowing only CMG to (certify and) distribute any UKCA configurations for science purpose.
6. (ongoing) MD to collate all UKCA parameters into ukca_constants in advance of removing duplicates already available in the UM and circulate details.
7. (ongoing) LA to put C_SPECIES definitions in the Redundant Code table (short-term), and switch to use M_SPECIES instead. Talk with JH about AQUM tests and requirements. Note that there will be problems with exoplanets and >100km top configs where M_air not constant.
8. (new) AJH to open ticket and assign to himself regarding loops over imode+n and imode-n.
9. (ongoing) MD/LA to talk about releases offline, and set up free-running and nudged GA7.1+StratTrop TS2000ish timeslice, with instructions to make it transient.
10. (new) NLA/MD make script for perpetual nudging (symbolic linking to existing files).
11. (new) NLA to port suite to ARCHER.
12. (ongoing) LA to create Wiki page on UKCA website for users to add details of configurations and input files.
13. (ongoing) ALL to review output from vn11.0 release candidate(s).
14. (new) MD to provide vn11.0 release candidate output again.
15. (ongoing) FOC to circulate doodle poll for further emissions discussion to CMG for all to fill-in. That meeting to report to CMG
16. (ongoing) MR to discuss with KP implications for GLOMAP in regards to a separate UKCA repository
17. (new) NLA to contact CEJ (cc JM) about trace-gas convective plume scavenging and how this will be impacted (or impact) the repository work
18. (ongoing) LA to contact FOC, AH, MR, KP, ATA, Ken Carslaw, Philip Stier regarding taking the proposal for a separate code repository forward.
19. (ongoing) FOC to see what action can be taken from MASS, then put out an email for POCs from institutes.
20. (new) FOC/AH/MD to develop a strategy on MASS for discussion at next CMG
21. (new) FOC to contact Garry Hayman to highlight bug #35.
22. (new) JM to take ownership of redundant code item #6 (Wet oxidation of SO2 in GLOMAP).
23. (new) LN to document redundant code item #9 (Deprecated UKCA netcdf attribute options).
24. (new) JM to do a catch-call ticket for GMED
25. (new) LN to l_fix_nh4no3_equilibrium in rose-stem and jobs and remove if necessary.
26. (new) NLA to do doodle poll for 90 minute meeting in first 2 weeks in November.

Standing actions

1. (ongoing - standing item) CMG to monitor list of bugs and circulate between group for owners.
2. (ongoing - standing item) At CMG future meetings there should be included an appendix listing the open bugs. If a ticket is included it is not an open bug (as the owner of ticket is person doing lodging).
3. (ongoing - standing item) ALL with access to keep monitoring ukca_bugs email list.
4. (ongoing - standing item) ALL to think about if code changes will change KGO and let systems team know in good time, and remember to include the UKCA & SC0138 keywords to all UKCA tickets. This should be a standard part of our working practice. Note also the required keywords.
5. (ongoing - standing item) ALL to note, review, and remove obsolete/redundant code
6. (ongoing - standing item) ALL closed ticket owners to produce a summary of their change for the UKCA newsletter
7. (ongoing - standing item) Code Owner to produce draft newsletter for CMG to approve.

Bugs/Bugfixes (LA)

Open Bugs

#	Description	Ticket	Owner	Status/ Updates	Comments from previous meetings	Comments from this meeting
35	Error in labelling: Surface resistance <--> stomatal resistance ?	UM:#1409	Fiona O'Connor		Leave open. Garry Hayman started work in offline JULES. Still ongoing. See action.
74	Bug in ukca_tropopause with definition of PV tropopause	UM:#1283 New ticket UM:#1367	Mohit Dalvi	Fix to be combined with Bug 75 below MOSRS: vn10.6_ukca_tropopause_amendment	Should make 11.2
75	Bug in STE fluxes	UM:#1367	Mohit Dalvi	Fix branch: vn11.1_ukca_fix_o3_ste will also include tropopause fix	Should make 11.2
87	Possible issues with YSTORE in UKCA_CHEMISTRY_CTL.	UM:#3245	Colin Johnson / Luke Abraham		Leave open. NLA to have another look. MS may have changed things with OMP changes.
96	Output drydiam diagnostics where l_ukca_arg_act but not l_ukca_radaer	UM:#3962	Alan J Hewitt	The beginnings of a solution are found in vn11.0_ukca_drydiam_activate_wo_radaer.	Leave open. AJH to take ownership - may be affected by reorganisation. Leave open.
98	Incorrect usage of npft integer when npft == 9 OR 13	UM:#4157	Alan J Hewitt / Garry Hayman	To be lodged at vn11.2 Follow-on ticket to remove temporary logical (l_fix_ukca_h2dd_x) UM:#4245	Under SciTech review. Logical will be removed after GA9.

Redundant Code (LA)

Code for deletion

PLEASE REMEMBER TO EDIT THE ORIGINAL REDUNDANT CODE TABLE AND NOT THIS PAGE

#	Description	Ticket	Remarks	Status	Timeframe	Owner	Comments from previous meetings	Comments from this meeting
2	Old dry deposition scheme	UM:#2356	None	PROPOSED	Medium-term	Nick Savage
4	ukca_strat_update.F90 - relax_ozone	UM:#1505	None	PROPOSED	Medium-term	Luke Abraham
5	Backward Euler Standard Tropospheric Chemistry	UM:#1507	None	PROPOSED	Medium-term	Fiona O'Connor
6	Wet oxidation of SO2 in GLOMAP	None	None	PROPOSED	Medium-term	Colin Johnson	JM to look at this re: UKESM1 c.f. offline GLOMAP. JM to take ownership.
7	Updraft velocity - l_conv_tke	UM:#3668	Proposed in December 2017. Approval being sought for GA series (likely GA8).	PROPOSED	Medium-term	Alan J Hewitt / Ian Boutle
8	All backward Euler chemistry schemes	None	Note that this is only for the “hard-coded” BE schemes. Quite a lot of work would be involved, but good as a longer-term aim. Note that problems for AQUM would need to be addressed first.	PROPOSED	Long-term	Luke Abraham
9	Deprecated UKCA netcdf attribute options	UM:#2513	'emission_type', string type attributes no longer recommeneded. Need some time for most new code to adopt these. Still used in AQUM files.	DEPRECATED	Medium-term	Nick Savage	AQUM are addressing the files. Have gone from operational jobs, have ticket to remove from rose-stem. LN to document.
10	ASAD families chemistry	None	Families chemistry has not been used for many years (since at least UM6.1. It is likely that it no longer works if turned on, and it complicates the code making other developments harder	DEPRECATED	Short-term	Luke Abraham
11	Dry deposition 9 PFT option	None	The 13 PFT option has been adopted for UKESM1. The 9 PFT option is possibly not being used at all. Proposed in June 2018.	PROPOSED	Long-term	Alan J Hewitt
12	Remove explicit C_SPECIES constants and calculate these from M_SPECIES and the mass of air	None	Will have wide-ranging rose-stem KGO breakages	PROPOSED	Short-term	Luke Abraham
13	Remove temporary logical l_fix_nacl_density Introduced at UM:#2405 by Colin Johnson	UM:#3490	Requires AMIP testing and a GMED ticket Could be accepted to GA9	PROPOSED	Medium-term	None	See JM GMED action
14	Remove temporary logical l_fix_nh4no3_equilibrium Introduced at UM:#646 by Carlos Ordonez	None	Requires AMIP testing and a GMED ticket Could be accepted to GA9	PROPOSED	Medium-term	None	See LN temporary logical action
15	Remove temporary logical l_fix_ukca_impscav Introduced at UM:#1421	UM:#4145	Approval being sought for GA series (likely GA9) GMED:#402	PROPOSED	Medium-term	Alan J Hewitt	See JM GMED action
16	Remove temporary logical l_fix_improve_drydep Introduced at UM:#1250	UM:#3997	Approval being sought for GA series (likely GA9) GMED:#393	PROPOSED	Medium-term	Alan J Hewitt	See JM GMED action
17	Remove temporary logical l_fix_ukca_h2dd_x Introduced at UM:#4157	UM:#4245	Approval being sought for GA series (likely GA9) GMED:#410	PROPOSED	Medium-term	Alan J Hewitt	See JM GMED action

UKCA Release Job (LA/MD)

Release Job UM11.0

See previous comments under actions from the last meeting.

Targets for vn11.3 (and beyond) (LA)

See details of the 29th October UM Developers and Owner's Group.

PLEASE REMEMBER TO INCLUDE THE KEYWORDS: UKCA & SC0138

Tickets targeting vn11.3

UM vn11.3 code review submission deadline is 7th Feb 2019. SOCRATES/JULES/GCOM/CASIM/KGO by 31st Jan 2019.

#	Description
UM:#3962	Output dry diameter diagnostic in niche case where l_ukca_arg_act but not l_ukca_radaer
UM:#3997	Retire temporary logical l_fix_improve_drydep
UM:#4024	Triggering of i_ukca_dms_flux by l_sulpc_so2
UM:#4145	Retire temporary logical l_fix_ukca_impscav
UM:#4201	Verify use of qsmin in UKCA plume scavenging diagnostics
UM:#4221	Optimisation of GLOMAP_CLIM
UM:#4231	Adding Common Representatives Intermediate (CRI) mechanism
UM:#4245	Retire temporary logical l_fix_ukca_h2dd_x