Minutes of the code management group meeting 2018-11-12
Teleconference Details
Monday 12th November 2018, 10am - 11.30am GMT
- UK Landline: +44 (0)1223 761376 (x61376 from an internal University of Cambridge phone)
- Participant PIN: 232764
Present
Met Office:
Cambridge:
Leeds:
Reading:
Lancaster:
Edinburgh:
UEA:
NIWA:
CSIRO:
Apologies:
Actions from this meeting
One-off actions
Standing actions
- (ongoing - standing item) CMG to monitor list of bugs and circulate between group for owners.
- (ongoing - standing item) At CMG future meetings there should be included an appendix listing the open bugs. If a ticket is included it is not an open bug (as the owner of ticket is person doing lodging).
- (ongoing - standing item) ALL with access to keep monitoring ukca_bugs email list.
- (ongoing - standing item) ALL to think about if code changes will change KGO and let systems team know in good time, and remember to include the UKCA & SC0138 keywords to all UKCA tickets. This should be a standard part of our working practice. Note also the required keywords.
- (ongoing - standing item) ALL to note, review, and remove obsolete/redundant code
- (ongoing - standing item) ALL closed ticket owners to produce a summary of their change for the UKCA newsletter
- (ongoing - standing item) Code Owner to produce draft newsletter for CMG to approve.
Minutes
Actions from the Last Meeting (LA)
Minutes of the code management group meeting 2018-09-05
One-off actions
- (ongoing) MY to check GLOMAP-mode code and report any missing bug fixes on the bugfixes page.
- MY starts in December for 4 months.
- Action: GM/MY to arrange telecon with LA when MY starts.
- (ongoing) LA to liaise with MY, and to chase MY and GM as to when this would be done.
- Closed
- (ongoing) LA to migrate PUMA UM tickets to MOSRS - see table below.
- Ongoing
- (ongoing) LA to open tickets for all changes that still require a ticket.
- Ongoing
- (ongoing) FOC to recommend at next Exec meeting a policy of allowing only CMG to (certify and) distribute any UKCA configurations for science purpose.
- Ongoing
- (ongoing) MD to collate all UKCA parameters into
ukca_constants
in advance of removing duplicates already available in the UM and circulate details.- Ongoing - will do at vn11.2
- (ongoing) LA to put
C_SPECIES
definitions in the Redundant Code table (short-term), and switch to useM_SPECIES
instead. Talk with JH about AQUM tests and requirements. Note that there will be problems with exoplanets and >100km top configs where M_air not constant.- AQUM tests will be straight-forward to check.
- Action: LA to make a branch and progress for vn11.3
- (new) AJH to open ticket and assign to himself regarding loops over imode+n and imode-n.
- Ongoing - ticket opened.
- Currently code is inflexible if add an extra mode. NB has similar ticket working on simplifications.
- Discuss with GM offline.
- (ongoing) MD/LA to talk about releases offline, and set up free-running and nudged GA7.1+StratTrop TS2000ish timeslice, with instructions to make it transient.
- See agenda item below.
- (new) NLA/MD make script for perpetual nudging (symbolic linking to existing files).
- Ongoing.
- (new) NLA to port suite to ARCHER.
- Closed.
- (ongoing) LA to create Wiki page on UKCA website for users to add details of configurations and input files.
- Ongoing.
- (ongoing) ALL to review output from vn11.0 release candidate(s).
- Closed. OM commented that Stratosphere looked good. LA highlighted that Stratospheric NOy is now merely low-biased.
- (new) MD to provide vn11.0 release candidate output again.
- Closed.
- (ongoing) FOC to circulate doodle poll for further emissions discussion to CMG for all to fill-in. That meeting to report to CMG
- Closed. Report at next CMG.
- (ongoing) MR to discuss with KP implications for GLOMAP in regards to a separate UKCA repository
- Ongoing, with general agreement that this needs to be done and is a good thing.
- Action: LA to forward NERC proposal to Leeds.
- (new) NLA to contact CEJ (cc JM) about trace-gas convective plume scavenging and how this will be impacted (or impact) the repository work
- Ongoing
- (ongoing) LA to contact FOC, AH, MR, KP, ATA, Ken Carslaw, Philip Stier regarding taking the proposal for a separate code repository forward.
- Closed. Generally positive feedback.
- (ongoing) FOC to see what action can be taken from MASS, then put out an email for POCs from institutes.
- Combine this in with action
- AH & FOC will take joint responsibility, and are still working out what information they can get on current usage and users.
- Roll discussion to next CMG.
- (new) FOC/AH/MD to develop a strategy on MASS for discussion at next
- Closed. Join with action above.
- (new) FOC to contact Garry Hayman to highlight bug #35.
- Closed.
- (new) JM to take ownership of redundant code item #6 (Wet oxidation of SO2 in GLOMAP).
- Closed.
- Action: JM to open a ticket and add to redundant code table.
- Keep GM/MY in the loop
- (new) LN to document redundant code item #9 (Deprecated UKCA netcdf attribute options).
- Closed - see below.
- (new) JM to do a catch-call ticket for GMED
- Ongoing
- (new) LN to l_fix_nh4no3_equilibrium in rose-stem and jobs and remove if necessary.
- Ticket open for vn11.3
- Already used in GA series, so should be quick to close.
- (new) NLA to do doodle poll for 90 minute meeting in first 2 weeks in November.
- Closed.
Standing actions
- (ongoing - standing item) CMG to monitor list of bugs and circulate between group for owners.
- (ongoing - standing item) At CMG future meetings there should be included an appendix listing the open bugs. If a ticket is included it is not an open bug (as the owner of ticket is person doing lodging).
- (ongoing - standing item) ALL with access to keep monitoring ukca_bugs email list.
- (ongoing - standing item) ALL to think about if code changes will change KGO and let systems team know in good time, and remember to include the UKCA & SC0138 keywords to all UKCA tickets. This should be a standard part of our working practice. Note also the required keywords.
- (ongoing - standing item) ALL to note, review, and remove obsolete/redundant code
- (ongoing - standing item) ALL closed ticket owners to produce a summary of their change for the UKCA newsletter
- (ongoing - standing item) Code Owner to produce draft newsletter for CMG to approve.
Bugs/Bugfixes (LA)
Open Bugs
# | Description | Ticket | Owner | Status/ Updates | Comments from previous meetings | Comments from this meeting |
---|---|---|---|---|---|---|
35 | Error in labelling: Surface resistance <--> stomatal resistance ? | UM:#1409 | Fiona O'Connor | Leave open. Garry Hayman started work in offline JULES. Still ongoing. See action. |
Leave open. JM found bug in SO2 deposition, where there is an inconsistency when change tiles. Action: JM to open ticket and new bug. | |
87 | Possible issues with YSTORE in UKCA_CHEMISTRY_CTL. | UM:#3245 | Colin Johnson / Luke Abraham | Leave open. NLA to have another look. MS may have changed things with OMP changes. | Ongoing. | |
96 | Output drydiam diagnostics where l_ukca_arg_act but not l_ukca_radaer | UM:#3962 | Alan J Hewitt | The beginnings of a solution are found in vn11.0_ukca_drydiam_activate_wo_radaer. | Leave open. AJH to take ownership - may be affected by reorganisation. Leave open. |
Ongoing. This just limits options. Leave until code is reorganised. |
100 | Negative concentrations of pvol_wat() | UM:#4383 | Alan J. Hewitt | Work ongoing to lodge at vn11.3 | In SciTech. | |
101 | Errors in reaction rates and diagnostics | UM:#4466 | Luke Abraham / Scott Archer-Nicolls | There is a need to conserve science config for UKESM1, so changes need to be on a flag. Colin has been looking at DMSO, as this is not currently used in StratTrop but is in Offline. Might be able to merge the rate with CEJ changes, but best to leave the diagnostic issues as a separate change. Action: LA, JM, CEJ, SAN to discuss offline and keep GM in loop. |
Redundant Code (LA)
Code for deletion
PLEASE REMEMBER TO EDIT THE ORIGINAL REDUNDANT CODE TABLE AND NOT THIS PAGE
# | Description | Ticket | Remarks | Status | Timeframe | Owner | Comments from previous meetings | Comments from this meeting |
---|---|---|---|---|---|---|---|---|
2 | Old dry deposition scheme | UM:#2356 | None | PROPOSED | Medium-term | Nick Savage | ||
4 | ukca_strat_update.F90 - relax_ozone | UM:#1505 | None | PROPOSED | Medium-term | Luke Abraham | ||
5 | Backward Euler Standard Tropospheric Chemistry | UM:#1507 | None | PROPOSED | Medium-term | Fiona O'Connor | ||
6 | Wet oxidation of SO2 in GLOMAP | None | None | PROPOSED | Medium-term | Colin Johnson | JM to look at this re: UKESM1 c.f. offline GLOMAP. JM to take ownership. | |
7 | Updraft velocity - l_conv_tke | UM:#3668 | Proposed in December 2017. Approval being sought for GA series (likely GA8). | PROPOSED | Medium-term | Alan J Hewitt / Ian Boutle | ||
8 | All backward Euler chemistry schemes | None | Note that this is only for the “hard-coded” BE schemes. Quite a lot of work would be involved, but good as a longer-term aim. Note that problems for AQUM would need to be addressed first. | PROPOSED | Long-term | Luke Abraham | ||
9 | Deprecated UKCA netcdf attribute options | UM:#2513 | 'emission_type', string type attributes no longer recommeneded. Need some time for most new code to adopt these. Still used in AQUM files. | DEPRECATED | Medium-term | Nick Savage | AQUM are addressing the files. Have gone from operational jobs, have ticket to remove from rose-stem. LN to document. | These have been removed from AQUM. Action: LA to contact AS and ask how best to proceed. |
10 | ASAD families chemistry | None | Families chemistry has not been used for many years (since at least UM6.1. It is likely that it no longer works if turned on, and it complicates the code making other developments harder | DEPRECATED | Short-term | Luke Abraham | ||
11 | Dry deposition 9 PFT option | None | The 13 PFT option has been adopted for UKESM1. The 9 PFT option is possibly not being used at all. Proposed in June 2018. |
PROPOSED | Long-term | Alan J Hewitt | ||
12 | Remove explicit C_SPECIES constants and calculate these from M_SPECIES and the mass of air |
None | Will have wide-ranging rose-stem KGO breakages | PROPOSED | Short-term | Luke Abraham | ||
13 | Remove temporary logical l_fix_nacl_density Introduced at UM:#2405 by Colin Johnson |
UM:#3490 | Requires AMIP testing and a GMED ticket Could be accepted to GA9 |
PROPOSED | Medium-term | None | See JM GMED action | |
14 | Remove temporary logical l_fix_nh4no3_equilibrium Introduced at UM:#646 by Carlos Ordonez |
None | Requires AMIP testing and a GMED ticket Could be accepted to GA9 |
PROPOSED | Medium-term | None | See LN temporary logical action | |
15 | Remove temporary logical l_fix_ukca_impscav Introduced at UM:#1421 |
UM:#4145 | Approval being sought for GA series (likely GA9) GMED:#402 |
PROPOSED | Medium-term | Alan J Hewitt | See JM GMED action | |
16 | Remove temporary logical l_fix_improve_drydep Introduced at UM:#1250 |
UM:#3997 | Approval being sought for GA series (likely GA9) GMED:#393 |
PROPOSED | Medium-term | Alan J Hewitt | See JM GMED action | |
17 | Remove temporary logical l_fix_ukca_h2dd_x Introduced at UM:#4157 |
UM:#4245 | Approval being sought for GA series (likely GA9) GMED:#410 |
PROPOSED | Medium-term | Alan J Hewitt | See JM GMED action | |
18 | Remove temporary logical l_fix_neg_pvol_wat Introduced at UM:#4383 |
UM:#4416 | Approval being sought for GA series (likely GA9) GMED:#421 |
PROPOSED | Medium-term | Alan J Hewitt |
UKCA Release Job (LA/MD)
See previous comments under actions from the last meeting.
ATA -- I have had a look at the Chemistry evaluation output. In general vn11 looks good to be released. As with other release versions I think it is important that we probably summarise a number of "features" of the model output. For example, the O3 STE is very low. I know Mohit has recently fixed the diagnostic and it would be good if this fix could be added and new output generated to confirm that the STE is so low. The other bits of the budget however look fine. The methane lifetime is a bit too short. But the age of air looks good relative to SF6. etc etc.
Targets for vn11.3 (and beyond) (LA)
See details of the 29th October UM Developers and Owner's Group.
PLEASE REMEMBER TO:
- INCLUDE THE KEYWORDS: UKCA & SC0138.
- ASSIGN THE TICKET AFTER ITS CREATION. NO TICKETS SHOULD BE LEFT AS NEW.
Tickets targeting vn11.3
UM vn11.3 code review submission deadline is 7th Feb 2019. SOCRATES/JULES/GCOM/CASIM/KGO by 31st Jan 2019.
# | Description |
---|---|
UM:#2689 | Enable coupling of GLOMAP-MODE Aerosol to FAST-JX photolysis. |
UM:#3127 | Investigate KGO differences in um_n48_ukca_eg app using GNU on the Cray |
UM:#3292 | Consolidate constant variables used by UKCA |
UM:#3367 | Removing transport of peroxy radical tracers in Strattrop (CHeST) |
UM:#3779 | Improvements to the inline comments in ukca_option_mod |
UM:#3959 | RO2-Permutation Chemistry |
UM:#3997 | Retire temporary logical l_fix_improve_drydep |
UM:#4001 | Magic numbers in ukca_setup_chem_mod.F90 |
UM:#4020 | Improved calculation of ozone dry deposition to ocean - surface resistance term |
UM:#4024 | Triggering of i_ukca_dms_flux by l_sulpc_so2 |
UM:#4131 | Enable use of ASAD Backward-Euler solver with UKCA offline oxidants chemistry |
UM:#4145 | Retire temporary logical l_fix_ukca_impscav |
UM:#4201 | Verify use of qsmin in UKCA plume scavenging diagnostics |
UM:#4221 | Optimisation of GLOMAP_CLIM |
UM:#4231 | Adding Common Representatives Intermediate (CRI) mechanism |
UM:#4245 | Retire temporary logical l_fix_ukca_h2dd_x |
UM:#4288 | Extend GLOMAP_CLIM rose stem testing to new compilers e.g. ifort & gfortran |
UM:#4357 | Replace glomap_clim_n48.nc in rose-stem/app/um_n48_glomap_clim (& n96) |
UM:#4375 | Implement cache-blocking loop in UKCA to optimise the chemistry solver |
UM:#4383 | Calculation of wts() masswaterkg() mdwat() pvol_wat() |
UM:#4397 | Rose stem test for i_ukca_chem=54 |
Owner for 4397
Ticket um:#3606 made fixes to allow the Newton-Raphson Offline Oxidants scheem to work, but there is currently no rose-stem test for this configuration to protect it. Ticket um:#4397 has been created for this, but currently does not have an owner.