Minutes of the code management group meeting 2025-01-09
Teleconference Details
Thursday 9th January 2025, 10.00am - 11.30am GMT
Meeting via Zoom - see link in calendar invitation
Met Office: MS, AJH, JH, MD, PMJ, AJ
Cambridge: NLA, RW
Leeds: MR
Canterbury:
CSIRO:
Apologies: AL, DG
NEXT MEETING WILL BE THURSDAY 13TH MARCH 2025, 10.00-11.30 GMT
Actions from this meeting
- (ongoing) NLA to put
C_SPECIESdefinitions in the Redundant Code table (short-term), and switch to useM_SPECIESinstead. Talk with JH about AQUM tests and requirements. Note that there will be problems with exoplanets and >100km top configs where M_air not constant. NLA to make a branch and progress. May want to move to redundant code table at some point. - (ongoing) GM/DG to update table on UKCA wiki documenting GLOMAP versions. DG/GM to consider the code and lodging process for GLOMAP developments and consider a suitable rose-stem test supported by NLA. GM Will work with DG to get a subset to commit.
- (ongoing) JH on update API document to UM13.6 release. NLA to provide feedback before it is be circulated. There is a comprehensive overhaul for 13.7. JH to make document available for wider information/comment.
- (ongoing) ALL look at um:#6203 showing other unprotected rose-stem options and think about any code/settings they are interested in.
- (ongoing) NLA, AJH to identify owner for TropChem item in the Desirable changes not Tested Table. AJH to arrange call with NLA to discuss this and creation of rose-stem jobs. Should also update the UKCA UMDP to reflect which configurations are supported/widely used. AJH & NLA to arrange a call to discuss this.
- (ongoing) ALL to consider ordering of the Progress with Priorities table and highlight things that should be higher priority, and any other tasks that need to be included.
- (ongoing) PMJ to look into a test to preserve functionality of NAME with UKCA. Functionality should still work after #170. Working with column model to replicate. Have suite to run on several platforms. PMJ to consider what the existing NAME test functionality is and whether it could be included within the UKCA working practices to protect the NAME work. PMJ to email NLA.
- (ongoing) NLA to add diagnostics to priorities table.
- (new) MR to send NLA and AJ the ticket/branch with changes for the moved GLOMAP files for comment. NLA to advise on code review process, and AJ to SciTech review.
Actions from the Last Meeting
- (ongoing) NLA to put
C_SPECIESdefinitions in the Redundant Code table (short-term), and switch to useM_SPECIESinstead. Talk with JH about AQUM tests and requirements. Note that there will be problems with exoplanets and >100km top configs where M_air not constant. NLA to make a branch and progress. May want to move to redundant code table at some point.- Ongoing
- (ongoing) GM/DG to update table on UKCA wiki documenting GLOMAP versions. DG/GM to consider the code and lodging process for GLOMAP developments and consider a suitable rose-stem test supported by NLA. GM Will work with DG to get a subset to commit.
- Ongoing
- (ongoing) JH on update API document to UM13.6 release. NLA to provide feedback before it is be circulated. There is a comprehensive overhaul for 13.7
- JH to make document available for wider information/comment
- Ongoing
- (ongoing) ALL look at um:#6203 showing other unprotected rose-stem options and think about any code/settings they are interested in.
- Ongoing
- (ongoing) NLA, AJH to identify owner for TropChem item in the Desirable changes not Tested Table. AJH to arrange call with NLA to discuss this and creation of rose-stem jobs. Should also update the UKCA UMDP to reflect which configurations are supported/widely used.
- AJH & NLA to arrange a call to discuss this
- Ongoing
- (ongoing) ALL to consider ordering of the Progress with Priorities table and highlight things that should be higher priority, and any other tasks that need to be included.
- Ongoing
- (ongoing) PMJ to look into a test to preserve functionality of NAME with UKCA. Functionality should still work after #170. Working with column model to replicate. Have suite to run on several platforms - will email NLA
- PMJ to consider what the existing NAME test functionality is and whether it could be included within the UKCA working practices to protect the NAME work
- Ongoing
- (new) NLA to rename milestones on UKCA Trac to better names.
- Decided to keep as they are, but add Summer/Autumn 2025
- Closed
- (new) NLA to add diagnostics to priorities table.
- See discussion below
- Ongoing
- (new) AJH to talk with AJ and Alistair Sellar regarding bug #144. GM can cross-check.
- See discussion below
- Closed
Tickets
PLEASE REMEMBER TO USE THE UKCA KEYWORD FOR ALL UKCA CHANGES (ESPECIALLY IMPORTANT FOR OTHER REPO TICKETS)
PLEASE REMEMBER TO USE THE LINKED:UM or LINKED:APPS KEYWORDS IN YOUR UKCA TICKET FOR LINKED CHANGES
PLEASE REMEMBER TO USE THE LINKED:UKCA KEYWORD IN YOUR LINKED UM and/or APPS TICKETS
NOTE: The requirement for LFric testing of all changes under UM:src/atmosphere, UKCA:src/science, and UKCA:src/control/core
Please also give any feedback on the UM release cycle to NLA to pass-back to UM Sys.
Message from UM Sys - please take care when considering keywords. It is important to get these correct for the Code Review process.
No commit order to send to UM Sys for this release, as seems like a straightforward set of tickets.
Current Release
Next Release
lfric_apps_repo - vn2.0 (Technical Dec-24)
lfric_apps_repo - vn2.1 (Feb-25)
Progress with Priorities (NLA)
ACTION REQUEST FROM UKCA SCIENCE & MANAGEMENT BOARD: CMG to provide list of priorities & their status, with particular thought to UKESM2 changes that will be required.
Progress with Priorities table
For diagnostics it was decided to have 2 levels
- Diagnostic infrastructure and high priority diagnostics that are needed for auto-assess and the UKCA evaluation suite (new #7)
- All other diagnostics (new #11 after GPU work)
AJH might need to start working on a RADAER API due to the need for multiple different imode settings. Will aim to do this year and should be 4-5 months of work.
Bugs/Bugfixes (NLA)
Open Bugs
| # | Description | Ticket | Owner | Comments | Comments from this meeting |
|---|---|---|---|---|---|
| 124 | H2 and N2 cannot be set for RCP and WMOA1 scenario routines | UM:#5620 | Mohit | Values are hard-wired in the code and cannot be changed without a branch | |
| 128 | Bug in UKCA stratospheric chemistry diagnostics | UM:#5839 | Luke Abraham | The indexing/values of diagnostics m01s50i101-i104 are incorrect. Fixes provided for vn11.1 and vn11.7. May affect CMIP6 diagnostics Does this need fixing for CMIP7? |
Need to discuss with CDDS/diagnostics team as might break existing workflow. |
| 143 | Error in print statements from UKCA_TRACERS_COPY_FROM_UM | Not yet | ??? | The final species listed in the diagnostic print statement seems to have very large concentrations (O(1E+08)) compared to others in the ppm-ppt range. Does not seem to affect model output. Reported by James Weber. | |
| 144 | interchangeable use of specific humidity and water vapour mixing ratio | #6813 | John Hemmings and ??? | UKCA includes calculations of relative humidity, clear-sky relative humidity and saturation vapour pressure. Relative humidity calculations should be based on water vapour mass mixing ratio but are in part based on specific humidity. Also, the calculation of saturation vapour pressure is derived from saturation mixing ratio but uses a formula for deriving SVP from saturation specific humidity. This interchangeable use of specific humidity (ratio for moist air) and mixing ratio (ratio for dry air) in existing configurations introduces small numerical errors in UM and LFRic model runs. These bugs were identified at UM version vn12.2 and have been highlighted by comments in code lodged with UM ticket #6660 (in ukca_main1-ukca_main1.F90 and atmos_ukca_humidity_mod.F90). All UKCA configurations are affected. Alan - This should be fixed by Met Office. I will speak with Anthony and Alistair about resourcing to fix this. It requires good understanding of humidity to work through this problem, otherwise I would have done this myself. When we pass stuff through the argument list, the name changes which makes things complicated. Should we pass a structure with all the humidity fields in? There is a UKCA bespoke version of humidity calculations for non-UM applications. Internal Met Office problem - will need to find someone to fix it. AJH to talk with AJ and Alistair Sellar. GM can cross-check. |
Ticket has 2 parts. JH suggests doing it in 2 tickets, 1 technical, 1 bug fix. JH could do technical part (either as callback routines or separate fields). Then would need UM & LFRic tickets for the bug fix, as calculations could be done in the parent or as callback routine. |
| 153 | bug in 2D photolysis | While working on developments for the new photolysis API, we’ve noticed a likely error in the current implementation of the 2D photolysis. The 2D photolysis files are tabulated by day of year at 5-day resolution, amongst other variables. The interpolation to the actual day of year is currently done in the read subroutine (read2d_opt or read2d_orig). However, this subroutine is only called once on the first timestep. For multi-day runs, the photolysis rates will not be updated as the day of year increases. Since nobody is using the 2D photolysis at the moment this is likely of low to no impact. | Might be used by NUAQ |
Redundant Code (NLA)
Code for deletion
PLEASE REMEMBER TO EDIT THE ORIGINAL REDUNDANT CODE TABLE AND NOT THIS PAGE
AJH believes that the 9PFT scheme can be removed, but may need to consider NAME/ACCESS requirements. Will currently leave as-is.
Desirable Science not tested
PLEASE REMEMBER TO EDIT THE ORIGINAL SCIENCE NOT TESTED TABLE AND NOT THIS PAGE
See also the complete list of unprotected rose-stem options
| # | Description | Ticket | Remarks | Owner |
|---|---|---|---|---|
| 1 | Use of tropospheric (2D) look-up table photolysis | Still useful to compare against FastJX. May be used for a "fast" configuration. Will be doen as part of photolysis refactoring | ||
| 2 | TropIsop chemistry configuration | May be useful in a "fast" configuration & to drive GLOMAP-mode. Useful for low-top configurations. | ||
| 3 | Strat chemistry configuration | Useful for stratospheric studies, particularly with a high model top. | Luke Abraham |
Round (virtual) Table of current activities, plans
| Person | Activity |
|---|---|
| NLA | Not heard about UKCA training yet |
A.O.B. & D.N.M. (NLA)
MR highlighted that some routines in the GLOMAP directory should be elsewhere, e.g. in emissions. He has a new starter who has identified these and has a UKCA branch that needs testing.
ACTION: MR to send NLA and AJ the ticket/branch with changes for the moved GLOMAP files for comment. NLA to advise on code review process, and AJ to SciTech review.
