Minutes of the code management group meeting 2024-11-14
Teleconference Details
Thursday 14th November 2024, 10.00am - 11.30am GMT
Meeting via Zoom - see link in calendar invitation
Met Office: MS, JH, CN, PMJ, MD, AJH
Cambridge: NLA, RW
Leeds: GM, MR
Canterbury:
CSIRO: AL
Apologies: DG, AJ
NEXT MEETING WILL BE THURSDAY 9TH JANUARY 2025, 10.00-11.30 GMT
Actions from this meeting
- (ongoing) NLA to put
C_SPECIES
definitions in the Redundant Code table (short-term), and switch to useM_SPECIES
instead. Talk with JH about AQUM tests and requirements. Note that there will be problems with exoplanets and >100km top configs where M_air not constant. NLA to make a branch and progress. May want to move to redundant code table at some point. - (ongoing) GM/DG to update table on UKCA wiki documenting GLOMAP versions. DG/GM to consider the code and lodging process for GLOMAP developments and consider a suitable rose-stem test supported by NLA. GM Will work with DG to get a subset to commit.
- (ongoing) JH on update API document to UM13.6 release. NLA to provide feedback before it is be circulated. There is a comprehensive overhaul for 13.7
- (ongoing) ALL look at um:#6203 showing other unprotected rose-stem options and think about any code/settings they are interested in.
- (ongoing) NLA, AJH to identify owner for TropChem item in the Desirable changes not Tested Table. AJH to arrange call with NLA to discuss this and creation of rose-stem jobs. Should also update the UKCA UMDP to reflect which configurations are supported/widely used.
- (ongoing) ALL to consider ordering of the Progress with Priorities table and highlight things that should be higher priority, and any other tasks that need to be included.
- (ongoing) PMJ to look into a test to preserve functionality of NAME with UKCA. Functionality should still work after #170. Working with column model to replicate. Have suite to run on several platforms - will email NLA
- (new) NLA to rename milestones on UKCA Trac to better names.
- (new) NLA to add diagnostics to priorities table.
- (new) AJH to talk with AJ and Alistair Sellar. GM can cross-check.
Actions from the Last Meeting
- (ongoing) NLA to put
C_SPECIES
definitions in the Redundant Code table (short-term), and switch to useM_SPECIES
instead. Talk with JH about AQUM tests and requirements. Note that there will be problems with exoplanets and >100km top configs where M_air not constant. NLA to make a branch and progress. May want to move to redundant code table at some point.- Ongoing
- (ongoing) GM/DG to update table on UKCA wiki documenting GLOMAP versions. DG/GM to consider the code and lodging process for GLOMAP developments and consider a suitable rose-stem test supported by NLA.
- Lodging process is time intensive so trying to find some time.
- The table is up to date as currently.
- Have made some progress with PSC improvements.
- GM Will work with DG to get a subset to commit.
- Ongoing
- (ongoing) JH on update API document to UM13.6 release. NLA to provide feedback before it is be circulated.
- Comprehensive overhaul for 13.7
- Ongoing
- (ongoing) ALL look at um:#6203 showing other unprotected rose-stem options and think about any code/settings they are interested in.
- Ongoing
- (ongoing) NLA, AJH to identify owner for TropChem item in the Desirable changes not Tested Table. AJH to arrange call with NLA to discuss this and creation of rose-stem jobs. Should also update the UKCA UMDP to reflect which configurations are supported/widely used.
- Ongoing
- (ongoing) ALL to consider ordering of the Progress with Priorities table and highlight things that should be higher priority, and any other tasks that need to be included.
- Ongoing
- (ongoing) NLA to contact Jonny at NIWA regarding a Cylc 8 Box model configuration.
- Closed
- (ongoing) NLA to add PSCs and thread safe work to Priorities table.
- Closed
- thread safe may not be used for name, and will not be done under NG-ARCH as the focus will be on GPU-porting.
- PMJ has been testing several approaches, from easy to hard. The first step is moving RAQ to use NR solver.
- (ongoing) MD to look at where to add photolysis API to Priorities table.
- Closed
- (ongoing) NLA to update working practices to highlight the need to check pressure-level versions of new diagnostics added.
- Closed
- (ongoing) NLA to tidy up redundant code table to take out people no longer working on UKCA.
- Closed
- (new) NLA to send round a Doodle Poll for early- to mid-November. We will fix the date for future UKCA CMG as well
- Closed
- (new) PMJ to look into a test to preserve functionality of NAME with UKCA. Functionality should still work after #170
- Ongoing
- Working with column model to replicate. Have suite to run on several platforms - will email NLA
- (new) All to use correct keywords and milestones in tickets for UKCA , UM , LFRIC_APPS
- Closed - standard working practice
Tickets
PLEASE REMEMBER TO USE THE UKCA KEYWORD FOR ALL UKCA CHANGES (ESPECIALLY IMPORTANT FOR OTHER REPO TICKETS)
PLEASE REMEMBER TO USE THE LINKED:UM or LINKED:APPS KEYWORDS IN YOUR UKCA TICKET FOR LINKED CHANGES
PLEASE REMEMBER TO USE THE LINKED:UKCA KEYWORD IN YOUR LINKED UM and/or APPS TICKETS
NOTE: The requirement for LFric testing
of all changes under UM:src/atmosphere, UKCA:src/science, and UKCA:src/control/core
Please also give any feedback on the UM release cycle to NLA to pass-back to UM Sys.
Message from UM Sys - please take care when considering keywords. It is important to get these correct for the Code Review process.
MR has found some files that should be in emissions rather than GLOMAP. AJH has been working on LFRic - RADAER and emissions ancillaries. CN has been working on photolysis.
ACTION: NLA to rename milestones to better names.
Current Release
Next Release
lfric_apps_repo - vn2.0 (Technical Dec-24)
lfric_apps_repo - vn2.1 (Feb-25)
Progress with Priorities (NLA)
ACTION REQUEST FROM UKCA SCIENCE & MANAGEMENT BOARD: CMG to provide list of priorities & their status, with particular thought to UKESM2 changes that will be required.
Progress with Priorities table
JH highlighted that work on diagnostics is not included in the table. This is a large and often hard to define task, and we are not sure how many will be transferred. Many need something to reflect that on the table. Note that we cannot yet consider diagnostics that consider persistent fields, e.g. STE and tendencies.
ACTION: Luke to add diagnostics to priorities table.
Bugs/Bugfixes (NLA)
Open Bugs
# | Description | Ticket | Owner | Comments | Comments from this meeting |
---|---|---|---|---|---|
124 | H2 and N2 cannot be set for RCP and WMOA1 scenario routines | UM:#5620 | Mohit | Values are hard-wired in the code and cannot be changed without a branch | |
128 | Bug in UKCA stratospheric chemistry diagnostics | UM:#5839 | Luke | The indexing/values of diagnostics m01s50i101-i104 are incorrect. Fixes provided for vn11.1 and vn11.7. May affect CMIP6 diagnostics | Does this need fixing for CMIP7? |
143 | Error in print statements from UKCA_TRACERS_COPY_FROM_UM | Not yet | ??? | The final species listed in the diagnostic print statement seems to have very large concentrations (O(1E+08)) compared to others in the ppm-ppt range. Does not seem to affect model output. Reported by James Weber. | |
144 | interchangeable use of specific humidity and water vapour mixing ratio | #6813 | ??? | UKCA includes calculations of relative humidity, clear-sky relative humidity and saturation vapour pressure. Relative humidity calculations should be based on water vapour mass mixing ratio but are in part based on specific humidity. Also, the calculation of saturation vapour pressure is derived from saturation mixing ratio but uses a formula for deriving SVP from saturation specific humidity. This interchangeable use of specific humidity (ratio for moist air) and mixing ratio (ratio for dry air) in existing configurations introduces small numerical errors in UM and LFRic model runs. These bugs were identified at UM version vn12.2 and have been highlighted by comments in code lodged with UM ticket #6660 (in ukca_main1-ukca_main1.F90 and atmos_ukca_humidity_mod.F90). All UKCA configurations are affected. | Alan - This should be fixed by Met Office. I will speak with Anthony and Alistair about resourcing to fix this. It requires good understanding of humidity to work through this problem, otherwise I would have done this myself. When we pass stuff through the argument list, the name changes which makes things complicated. Should we pass a structure with all the humidity fields in? There is a UKCA bespoke version of humidity calculations for non-UM applications. Internal Met Office problem - will need to find someone to fix it. ACTION: AJH to talk with AJ and Alistair Sellar. GM can cross-check. |
145 | all_ntp not explicitly dimensioned in UKCA_MAIN | ??? | Not yet Possible fix here |
all_ntp not being dimensioned explicitly in ukca_main1-ukca_main1.F90. Highlighted in NCAS CMS ticket https://cms-helpdesk.ncas.ac.uk/t/nested-ukca-suite-on-archer2/604 raised by Paul Field. Grenville Lister has found the cause and implemented a possible fix https://code.metoffice.gov.uk/trac/um/changeset/110132/main/branches/dev/grenvillelister/vn12.0_all_ntp_fix |
NLA to take ownership |
150 | ukca_ddepctl bug for 27 tiles | ukca:#19 | ??? | Will alter results of 27 tile ukesm1 runs. Fixed in Jules code by Garry, so no bug in UKESM2. |
Alan - It is suggested that we would rather preserve answers than make a change. I will close this bug as wont fix (as it will not be present in UKESM2 anyway). Can let this one retire itself. Minimal changes, keep for consistency. WONTFIX |
153 | bug in 2D photolysis | While working on developments for the new photolysis API, we’ve noticed a likely error in the current implementation of the 2D photolysis. The 2D photolysis files are tabulated by day of year at 5-day resolution, amongst other variables. The interpolation to the actual day of year is currently done in the read subroutine (read2d_opt or read2d_orig). However, this subroutine is only called once on the first timestep. For multi-day runs, the photolysis rates will not be updated as the day of year increases. Since nobody is using the 2D photolysis at the moment this is likely of low to no impact. |
Redundant Code (NLA)
Code for deletion
PLEASE REMEMBER TO EDIT THE ORIGINAL REDUNDANT CODE TABLE AND NOT THIS PAGE
Desirable Science not tested
PLEASE REMEMBER TO EDIT THE ORIGINAL SCIENCE NOT TESTED TABLE AND NOT THIS PAGE
See also the complete list of unprotected rose-stem options
# | Description | Ticket | Remarks | Owner |
---|---|---|---|---|
1 | Use of tropospheric (2D) look-up table photolysis | Still useful to compare against FastJX. May be used for a "fast" configuration. Will be doen as part of photolysis refactoring | ||
2 | TropIsop chemistry configuration | May be useful in a "fast" configuration & to drive GLOMAP-mode. Useful for low-top configurations. | ||
3 | Strat chemistry configuration | Useful for stratospheric studies, particularly with a high model top. | Luke Abraham |
Round (virtual) Table of current activities, plans
Person | Activity |
---|---|
NLA | Submitted bid for UKCA training to NERC |