Difference between revisions of "Redundant code"

From UKCA
Line 32: Line 32:
 
| 8 || All backward Euler chemistry schemes || None || Note that this is only for the “hard-coded” BE schemes. <br/> Quite a lot of work would be involved, but good as a longer-term aim. <br/> ''Note'' that problems for AQUM would need to be addressed first. || '''PROPOSED''' || Long-term || Luke Abraham ||
 
| 8 || All backward Euler chemistry schemes || None || Note that this is only for the “hard-coded” BE schemes. <br/> Quite a lot of work would be involved, but good as a longer-term aim. <br/> ''Note'' that problems for AQUM would need to be addressed first. || '''PROPOSED''' || Long-term || Luke Abraham ||
 
|-
 
|-
| 9 || Deprecated UKCA netcdf attribute options || [https://code.metoffice.gov.uk/trac/um/ticket/2513 UM:#2513] || 'emission_type', string type attributes no longer recommeneded. <br/> Need some time for most new code to adopt these. <br/> Still used in AQUM files. || '''DEPRECATED''' || Long-term || Nick Savage ||
+
| 9 || Deprecated UKCA netcdf attribute options || [https://code.metoffice.gov.uk/trac/um/ticket/2513 UM:#2513] || 'emission_type', string type attributes no longer recommeneded. <br/> Need some time for most new code to adopt these. <br/> Still used in AQUM rose stem files - will be removed in [https://code.metoffice.gov.uk/trac/um/ticket/3985 UM:#3985]. || '''DEPRECATED''' || Long-term || Nick Savage ||
 
|-
 
|-
 
| 10 || ASAD families chemistry || None || Families chemistry has not been used for many years (since at least UM6.1). <br/> It is likely that it no longer works if turned on, and it complicates the code making other developments harder || '''DEPRECATED''' || Short-term || Luke Abraham ||
 
| 10 || ASAD families chemistry || None || Families chemistry has not been used for many years (since at least UM6.1). <br/> It is likely that it no longer works if turned on, and it complicates the code making other developments harder || '''DEPRECATED''' || Short-term || Luke Abraham ||

Revision as of 13:38, 6 September 2018

This page is a starting point for discussion on code which is not being used and can be considered for removal. At this stage no decisions about any of these pieces of code have been made but in time it will become a place to record when things are planned to be deleted and then when they are deleted.

Table of code proposed for deletion

Status should be "proposed" until agreed for deletion at a code management group meeting. However, you are encouraged to open a ticket with the milestone set to 'HOPEFULLY' as soon as you propose something here. If the proposal is rejected the ticket can be closed. Code that exists but it no longer used can be set to depreciated.

NOTE: ALL GLOMAP CHANGES SHOULD BE DISCUSSED WITH LEEDS BEFORE PROCEEDING

# Description Ticket Remarks Status Timeframe Owner
1 Old emissions code (that which uses ancil files) UM:#142 None Complete Nick Savage
2 Old dry deposition scheme UM:#2356 None PROPOSED Medium-term Nick Savage
3 ukca_volume_mode.F90
quick method for calculating wet volume is not used.
UM:#2373 iwvolmethod removed. Complete Alan J Hewitt
4 ukca_strat_update.F90 - relax_ozone UM:#1505 None PROPOSED Medium-term Luke Abraham
5 Backward Euler Standard Tropospheric Chemistry UM:#1507 None PROPOSED Medium-term Fiona O'Connor
6 Wet oxidation of SO2 in GLOMAP None None PROPOSED
Medium-term
Colin Johnson
7 Retire l_conv_tke (Updraft velocity)
Introduced at UM:#1645
UM:#3668 Approval being sought for GA series (likely GA8)
GA7.0 GMED:#197 and GA7.1 GMED:#286
Ticket passed to Ian Boutle
PROPOSED Medium-term Ian Boutle
8 All backward Euler chemistry schemes None Note that this is only for the “hard-coded” BE schemes.
Quite a lot of work would be involved, but good as a longer-term aim.
Note that problems for AQUM would need to be addressed first.
PROPOSED Long-term Luke Abraham
9 Deprecated UKCA netcdf attribute options UM:#2513 'emission_type', string type attributes no longer recommeneded.
Need some time for most new code to adopt these.
Still used in AQUM rose stem files - will be removed in UM:#3985.
DEPRECATED Long-term Nick Savage
10 ASAD families chemistry None Families chemistry has not been used for many years (since at least UM6.1).
It is likely that it no longer works if turned on, and it complicates the code making other developments harder
DEPRECATED Short-term Luke Abraham
11 Dry deposition 9 PFT option UM:#4259 The 13 PFT option has been adopted for UKESM1.
The 9 PFT option is possibly not being used at all.
Proposed in June 2018.
PROPOSED Long-term Alan J Hewitt
12 Remove explicit C_SPECIES constants and calculate these from M_SPECIES and the mass of air None Will have wide-ranging rose-stem KGO breakages PROPOSED Short-term Luke Abraham
13 Remove temporary logical l_fix_nacl_density
Introduced at UM:#2405 by Colin Johnson
UM:#3490 Requires AMIP testing and a GMED ticket
Could be accepted to GA9
PROPOSED Medium-term None
14 Remove temporary logical l_fix_nh4no3_equilibrium
Introduced at UM:#646 by Carlos Ordonez
None Requires AMIP testing and a GMED ticket
Could be accepted to GA9
PROPOSED Medium-term None
15 Remove temporary logical l_fix_ukca_impscav
Introduced at UM:#1421
UM:#4145 Approval being sought for GA series (likely GA9)
GMED:#402
PROPOSED Medium-term Alan J Hewitt
16 Remove temporary logical l_fix_improve_drydep
Introduced at UM:#1250
UM:#3997 Approval being sought for GA series (likely GA9)
GMED:#393
PROPOSED Medium-term Alan J Hewitt
17 Remove temporary logical l_fix_ukca_h2dd_x
Introduced at UM:#4157
UM:#4245 Approval being sought for GA series (likely GA9)
GMED:#410
PROPOSED Medium-term Alan J Hewitt