Difference between revisions of "Redundant code"
From UKCA
Line 16: | Line 16: | ||
!style="text-align:top;|Owner |
!style="text-align:top;|Owner |
||
|- |
|- |
||
− | | 1 || Old emissions code (that which uses ancil files) || [https://code.metoffice.gov.uk/trac/um/ticket/142 UM:#142] || None || '''Complete''' || || Nick Savage |
+ | | 1 || Old emissions code (that which uses ancil files) || [https://code.metoffice.gov.uk/trac/um/ticket/142 UM:#142] || None || '''Complete''' || || Nick Savage |
|- |
|- |
||
− | | 2 || Old dry deposition scheme || [https://code.metoffice.gov.uk/trac/um/ticket/2356 UM:#2356] || None || '''PROPOSED''' || Medium-term || Nick Savage |
+ | | 2 || Old dry deposition scheme || [https://code.metoffice.gov.uk/trac/um/ticket/2356 UM:#2356] || None || '''PROPOSED''' || Medium-term || Nick Savage |
|- |
|- |
||
− | | 3 || ukca_volume_mode.F90 <br/> quick method for calculating wet volume is not used. || [https://code.metoffice.gov.uk/trac/um/ticket/2373 UM:#2373] || iwvolmethod removed. || '''Complete''' || || Alan J Hewitt |
+ | | 3 || ukca_volume_mode.F90 <br/> quick method for calculating wet volume is not used. || [https://code.metoffice.gov.uk/trac/um/ticket/2373 UM:#2373] || iwvolmethod removed. || '''Complete''' || || Alan J Hewitt |
|- |
|- |
||
− | | 4 || ukca_strat_update.F90 - relax_ozone || [https://code.metoffice.gov.uk/trac/um/ticket/1505 UM:#1505] || None || '''PROPOSED''' || Medium-term || Luke Abraham |
+ | | 4 || ukca_strat_update.F90 - relax_ozone || [https://code.metoffice.gov.uk/trac/um/ticket/1505 UM:#1505] || None || '''PROPOSED''' || Medium-term || Luke Abraham |
|- |
|- |
||
− | | 5 || Backward Euler Standard Tropospheric Chemistry || [https://code.metoffice.gov.uk/trac/um/ticket/1507 UM:#1507] || None || '''PROPOSED''' || Medium-term || Fiona O'Connor |
+ | | 5 || Backward Euler Standard Tropospheric Chemistry || [https://code.metoffice.gov.uk/trac/um/ticket/1507 UM:#1507] || None || '''PROPOSED''' || Medium-term || Fiona O'Connor |
|- |
|- |
||
− | | 6 || Wet oxidation of SO2 in GLOMAP || None || None || '''PROPOSED''' ||<br/> Medium-term || Colin Johnson |
+ | | 6 || Wet oxidation of SO2 in GLOMAP || None || None || '''PROPOSED''' ||<br/> Medium-term || Colin Johnson |
|-<br/> |
|-<br/> |
||
− | | 7 || Retire l_conv_tke (Updraft velocity) <br/> Introduced at [https://code.metoffice.gov.uk/trac/um/ticket/1645 UM:#1645] || [https://code.metoffice.gov.uk/trac/um/ticket/3668 UM:#3668] || Approval being sought for GA series (likely GA8) <br/> GA7.0 [https://code.metoffice.gov.uk/trac/gmed/ticket/197 GMED:#197] and GA7.1 [https://code.metoffice.gov.uk/trac/gmed/ticket/286 GMED:#286] <br/> Ticket passed to Ian Boutle || '''PROPOSED''' || Medium-term || Ian Boutle |
+ | | 7 || Retire l_conv_tke (Updraft velocity) <br/> Introduced at [https://code.metoffice.gov.uk/trac/um/ticket/1645 UM:#1645] || [https://code.metoffice.gov.uk/trac/um/ticket/3668 UM:#3668] || Approval being sought for GA series (likely GA8) <br/> GA7.0 [https://code.metoffice.gov.uk/trac/gmed/ticket/197 GMED:#197] and GA7.1 [https://code.metoffice.gov.uk/trac/gmed/ticket/286 GMED:#286] <br/> Ticket passed to Ian Boutle || '''PROPOSED''' || Medium-term || Ian Boutle |
|- |
|- |
||
− | | 8 || All backward Euler chemistry schemes || None || Note that this is only for the “hard-coded” BE schemes. <br/> Quite a lot of work would be involved, but good as a longer-term aim. <br/> ''Note'' that problems for AQUM would need to be addressed first. || '''PROPOSED''' || Long-term || Luke Abraham |
+ | | 8 || All backward Euler chemistry schemes || None || Note that this is only for the “hard-coded” BE schemes. <br/> Quite a lot of work would be involved, but good as a longer-term aim. <br/> ''Note'' that problems for AQUM would need to be addressed first. || '''PROPOSED''' || Long-term || Luke Abraham |
|- |
|- |
||
− | | 9 || Deprecated UKCA netcdf attribute options || [https://code.metoffice.gov.uk/trac/um/ticket/2513 UM:#2513] || 'emission_type', string type attributes no longer recommeneded. <br/> Need some time for most new code to adopt these. <br/> Still used in AQUM rose stem files - will be removed in [https://code.metoffice.gov.uk/trac/um/ticket/3985 UM:#3985]. || '''DEPRECATED''' || Long-term || Nick Savage |
+ | | 9 || Deprecated UKCA netcdf attribute options || [https://code.metoffice.gov.uk/trac/um/ticket/2513 UM:#2513] || 'emission_type', string type attributes no longer recommeneded. <br/> Need some time for most new code to adopt these. <br/> Still used in AQUM rose stem files - will be removed in [https://code.metoffice.gov.uk/trac/um/ticket/3985 UM:#3985]. || '''DEPRECATED''' || Long-term || Nick Savage |
|- |
|- |
||
− | | 10 || ASAD families chemistry || None || Families chemistry has not been used for many years (since at least UM6.1). <br/> It is likely that it no longer works if turned on, and it complicates the code making other developments harder || '''DEPRECATED''' || Short-term || Luke Abraham |
+ | | 10 || ASAD families chemistry || None || Families chemistry has not been used for many years (since at least UM6.1). <br/> It is likely that it no longer works if turned on, and it complicates the code making other developments harder || '''DEPRECATED''' || Short-term || Luke Abraham |
|- |
|- |
||
− | | 11 || Dry deposition 9 PFT option || [https://code.metoffice.gov.uk/trac/um/ticket/4259 UM:#4259] || The 13 PFT option has been adopted for UKESM1. <br/> The 9 PFT option is possibly not being used at all. <br/> Proposed in June 2018. || '''PROPOSED''' || Long-term || Alan J Hewitt |
+ | | 11 || Dry deposition 9 PFT option || [https://code.metoffice.gov.uk/trac/um/ticket/4259 UM:#4259] || The 13 PFT option has been adopted for UKESM1. <br/> The 9 PFT option is possibly not being used at all. <br/> Proposed in June 2018. || '''PROPOSED''' || Long-term || Alan J Hewitt |
|- |
|- |
||
− | | 12 || Remove explicit <code>C_SPECIES</code> constants and calculate these from <code>M_SPECIES</code> and the mass of air || None || Will have wide-ranging rose-stem KGO breakages || '''PROPOSED''' || Short-term || Luke Abraham |
+ | | 12 || Remove explicit <code>C_SPECIES</code> constants and calculate these from <code>M_SPECIES</code> and the mass of air || None || Will have wide-ranging rose-stem KGO breakages || '''PROPOSED''' || Short-term || Luke Abraham |
|- |
|- |
||
− | | 13 || Remove temporary logical l_fix_nacl_density <br/> Introduced at [https://code.metoffice.gov.uk/trac/um/ticket/2405 UM:#2405] by Colin Johnson || [https://code.metoffice.gov.uk/trac/um/ticket/3490 UM:#3490] || Approval being sought for GA series (likely GA9) <br/> [https://code.metoffice.gov.uk/trac/gmed/ticket/426 GMED:#426] || '''PROPOSED''' || Medium-term || Jane Mulcahy |
+ | | 13 || Remove temporary logical l_fix_nacl_density <br/> Introduced at [https://code.metoffice.gov.uk/trac/um/ticket/2405 UM:#2405] by Colin Johnson || [https://code.metoffice.gov.uk/trac/um/ticket/3490 UM:#3490] || Approval being sought for GA series (likely GA9) <br/> [https://code.metoffice.gov.uk/trac/gmed/ticket/426 GMED:#426] || '''PROPOSED''' || Medium-term || Jane Mulcahy |
|- |
|- |
||
− | | 14 || Remove temporary logical l_fix_nh4no3_equilibrium <br/> Introduced at [https://code.metoffice.gov.uk/trac/um/ticket/646 UM:#646] || [https://code.metoffice.gov.uk/trac/um/ticket/4382 UM:#4382] || l_fix_nh4no3_equilibrium removed || '''Complete''' || || Pedro Molina-Jimenez |
+ | | 14 || Remove temporary logical l_fix_nh4no3_equilibrium <br/> Introduced at [https://code.metoffice.gov.uk/trac/um/ticket/646 UM:#646] || [https://code.metoffice.gov.uk/trac/um/ticket/4382 UM:#4382] || l_fix_nh4no3_equilibrium removed || '''Complete''' || || Pedro Molina-Jimenez |
|- |
|- |
||
− | | 15 || Remove temporary logical l_fix_ukca_impscav <br/> Introduced at [https://code.metoffice.gov.uk/trac/um/ticket/1421 UM:#1421] || [https://code.metoffice.gov.uk/trac/um/ticket/4145 UM:#4145] || Approval being sought for GA series (likely GA9) <br/> [https://code.metoffice.gov.uk/trac/gmed/ticket/402 GMED:#402] || '''PROPOSED''' || Medium-term || Alan J Hewitt |
+ | | 15 || Remove temporary logical l_fix_ukca_impscav <br/> Introduced at [https://code.metoffice.gov.uk/trac/um/ticket/1421 UM:#1421] || [https://code.metoffice.gov.uk/trac/um/ticket/4145 UM:#4145] || Approval being sought for GA series (likely GA9) <br/> [https://code.metoffice.gov.uk/trac/gmed/ticket/402 GMED:#402] || '''PROPOSED''' || Medium-term || Alan J Hewitt |
|- |
|- |
||
− | | 16 || Remove temporary logical l_fix_improve_drydep <br/> Introduced at [https://code.metoffice.gov.uk/trac/um/ticket/1250 UM:#1250] || [https://code.metoffice.gov.uk/trac/um/ticket/3997 UM:#3997] || Approval being sought for GA series (likely GA9) <br/> [https://code.metoffice.gov.uk/trac/gmed/ticket/393 GMED:#393] || '''PROPOSED''' || Medium-term || Alan J Hewitt |
+ | | 16 || Remove temporary logical l_fix_improve_drydep <br/> Introduced at [https://code.metoffice.gov.uk/trac/um/ticket/1250 UM:#1250] || [https://code.metoffice.gov.uk/trac/um/ticket/3997 UM:#3997] || Approval being sought for GA series (likely GA9) <br/> [https://code.metoffice.gov.uk/trac/gmed/ticket/393 GMED:#393] || '''PROPOSED''' || Medium-term || Alan J Hewitt |
|- |
|- |
||
− | | 17 || Remove temporary logical l_fix_ukca_h2dd_x <br/> Introduced at [https://code.metoffice.gov.uk/trac/um/ticket/4157 UM:#4157] || [https://code.metoffice.gov.uk/trac/um/ticket/4245 UM:#4245] || Approval being sought for GA series (likely GA9) <br/> [https://code.metoffice.gov.uk/trac/gmed/ticket/410 GMED:#410] || '''PROPOSED''' || Medium-term || Alan J Hewitt |
+ | | 17 || Remove temporary logical l_fix_ukca_h2dd_x <br/> Introduced at [https://code.metoffice.gov.uk/trac/um/ticket/4157 UM:#4157] || [https://code.metoffice.gov.uk/trac/um/ticket/4245 UM:#4245] || Approval being sought for GA series (likely GA9) <br/> [https://code.metoffice.gov.uk/trac/gmed/ticket/410 GMED:#410] || '''PROPOSED''' || Medium-term || Alan J Hewitt |
|- |
|- |
||
− | | 18 || Remove temporary logical l_fix_neg_pvol_wat <br/> Introduced at [https://code.metoffice.gov.uk/trac/um/ticket/4383 UM:#4383] || [https://code.metoffice.gov.uk/trac/um/ticket/4416 UM:#4416] || Approval being sought for GA series (likely GA9) <br/> [https://code.metoffice.gov.uk/trac/gmed/ticket/421 GMED:#421] || '''PROPOSED''' || Medium-term || Alan J Hewitt |
+ | | 18 || Remove temporary logical l_fix_neg_pvol_wat <br/> Introduced at [https://code.metoffice.gov.uk/trac/um/ticket/4383 UM:#4383] || [https://code.metoffice.gov.uk/trac/um/ticket/4416 UM:#4416] || Approval being sought for GA series (likely GA9) <br/> [https://code.metoffice.gov.uk/trac/gmed/ticket/421 GMED:#421] || '''PROPOSED''' || Medium-term || Alan J Hewitt |
|- |
|- |
||
− | | 19 || Remove MODULEs/SUBROUTINEs/FUNCTIONs <br/> within UKCA not called within the UM: <br/> <br/> SUBROUTINE asad_dealloc_chemdiag <br/> FUNCTION cd_findspeciesloc <br/> SUBROUTINE asad_lin_diagnostic <br/> MODULE asad_emissn_mod and SUBROUTINE asad_emissn <br/> FUNCTION prcount <br/> MODULE asad_inemit_mod and SUBROUTINE asad_inemit <br/> MODULE asad_inhet_mod and SUBROUTINE asad_inhet <br/> MODULE asad_inphot_mod and SUBROUTINE asad_inphot <br/> SUBROUTINE asad_mod_final <br/> MODULE asad_ycn_mod and SUBROUTINE asad_ycn <br/> MODULE quanto1d_mod and SUBROUTINE quanto1d <br/> SUBROUTINE activmkpdf <br/> MODULE ukca_fixedsb_mod and SUBROUTINE ukca_fixedsb <br/> SUBROUTINE deallocate_radaer_struct <br/> SUBROUTINE ukca_relax_ozone || [https://code.metoffice.gov.uk/trac/um/ticket/4512 UM:#4512] || Not called within UM <br/> Need to decide whether any should be kept <br/> <br/> [https://code.metoffice.gov.uk/trac/um/log/main/branches/dev/alanjhewitt/vn11.3_remove_redundant_UKCA_code vn11.3_remove_redundant_UKCA_code]|| '''DEPRECATED''' || Short-term || Alan J Hewitt |
+ | | 19 || Remove MODULEs/SUBROUTINEs/FUNCTIONs <br/> within UKCA not called within the UM: <br/> <br/> SUBROUTINE asad_dealloc_chemdiag <br/> FUNCTION cd_findspeciesloc <br/> SUBROUTINE asad_lin_diagnostic <br/> MODULE asad_emissn_mod and SUBROUTINE asad_emissn <br/> FUNCTION prcount <br/> MODULE asad_inemit_mod and SUBROUTINE asad_inemit <br/> MODULE asad_inhet_mod and SUBROUTINE asad_inhet <br/> MODULE asad_inphot_mod and SUBROUTINE asad_inphot <br/> SUBROUTINE asad_mod_final <br/> MODULE asad_ycn_mod and SUBROUTINE asad_ycn <br/> MODULE quanto1d_mod and SUBROUTINE quanto1d <br/> SUBROUTINE activmkpdf <br/> MODULE ukca_fixedsb_mod and SUBROUTINE ukca_fixedsb <br/> SUBROUTINE deallocate_radaer_struct <br/> SUBROUTINE ukca_relax_ozone || [https://code.metoffice.gov.uk/trac/um/ticket/4512 UM:#4512] || Not called within UM <br/> Need to decide whether any should be kept <br/> <br/> [https://code.metoffice.gov.uk/trac/um/log/main/branches/dev/alanjhewitt/vn11.3_remove_redundant_UKCA_code vn11.3_remove_redundant_UKCA_code]|| '''DEPRECATED''' || Short-term || Alan J Hewitt |
|} |
|} |
Revision as of 14:45, 27 March 2019
This page is a starting point for discussion on code which is not being used and can be considered for removal. At this stage no decisions about any of these pieces of code have been made but in time it will become a place to record when things are planned to be deleted and then when they are deleted.
Table of code proposed for deletion
Status should be "proposed" until agreed for deletion at a code management group meeting. However, you are encouraged to open a ticket with the milestone set to 'HOPEFULLY' as soon as you propose something here. If the proposal is rejected the ticket can be closed. Code that exists but it no longer used can be set to depreciated.
NOTE: ALL GLOMAP CHANGES SHOULD BE DISCUSSED WITH LEEDS BEFORE PROCEEDING
# | Description | Ticket | Remarks | Status | Timeframe | Owner |
---|---|---|---|---|---|---|
1 | Old emissions code (that which uses ancil files) | UM:#142 | None | Complete | Nick Savage | |
2 | Old dry deposition scheme | UM:#2356 | None | PROPOSED | Medium-term | Nick Savage |
3 | ukca_volume_mode.F90 quick method for calculating wet volume is not used. |
UM:#2373 | iwvolmethod removed. | Complete | Alan J Hewitt | |
4 | ukca_strat_update.F90 - relax_ozone | UM:#1505 | None | PROPOSED | Medium-term | Luke Abraham |
5 | Backward Euler Standard Tropospheric Chemistry | UM:#1507 | None | PROPOSED | Medium-term | Fiona O'Connor |
6 | Wet oxidation of SO2 in GLOMAP | None | None | PROPOSED | Medium-term |
Colin Johnson |
7 | Retire l_conv_tke (Updraft velocity) Introduced at UM:#1645 |
UM:#3668 | Approval being sought for GA series (likely GA8) GA7.0 GMED:#197 and GA7.1 GMED:#286 Ticket passed to Ian Boutle |
PROPOSED | Medium-term | Ian Boutle |
8 | All backward Euler chemistry schemes | None | Note that this is only for the “hard-coded” BE schemes. Quite a lot of work would be involved, but good as a longer-term aim. Note that problems for AQUM would need to be addressed first. |
PROPOSED | Long-term | Luke Abraham |
9 | Deprecated UKCA netcdf attribute options | UM:#2513 | 'emission_type', string type attributes no longer recommeneded. Need some time for most new code to adopt these. Still used in AQUM rose stem files - will be removed in UM:#3985. |
DEPRECATED | Long-term | Nick Savage |
10 | ASAD families chemistry | None | Families chemistry has not been used for many years (since at least UM6.1). It is likely that it no longer works if turned on, and it complicates the code making other developments harder |
DEPRECATED | Short-term | Luke Abraham |
11 | Dry deposition 9 PFT option | UM:#4259 | The 13 PFT option has been adopted for UKESM1. The 9 PFT option is possibly not being used at all. Proposed in June 2018. |
PROPOSED | Long-term | Alan J Hewitt |
12 | Remove explicit C_SPECIES constants and calculate these from M_SPECIES and the mass of air |
None | Will have wide-ranging rose-stem KGO breakages | PROPOSED | Short-term | Luke Abraham |
13 | Remove temporary logical l_fix_nacl_density Introduced at UM:#2405 by Colin Johnson |
UM:#3490 | Approval being sought for GA series (likely GA9) GMED:#426 |
PROPOSED | Medium-term | Jane Mulcahy |
14 | Remove temporary logical l_fix_nh4no3_equilibrium Introduced at UM:#646 |
UM:#4382 | l_fix_nh4no3_equilibrium removed | Complete | Pedro Molina-Jimenez | |
15 | Remove temporary logical l_fix_ukca_impscav Introduced at UM:#1421 |
UM:#4145 | Approval being sought for GA series (likely GA9) GMED:#402 |
PROPOSED | Medium-term | Alan J Hewitt |
16 | Remove temporary logical l_fix_improve_drydep Introduced at UM:#1250 |
UM:#3997 | Approval being sought for GA series (likely GA9) GMED:#393 |
PROPOSED | Medium-term | Alan J Hewitt |
17 | Remove temporary logical l_fix_ukca_h2dd_x Introduced at UM:#4157 |
UM:#4245 | Approval being sought for GA series (likely GA9) GMED:#410 |
PROPOSED | Medium-term | Alan J Hewitt |
18 | Remove temporary logical l_fix_neg_pvol_wat Introduced at UM:#4383 |
UM:#4416 | Approval being sought for GA series (likely GA9) GMED:#421 |
PROPOSED | Medium-term | Alan J Hewitt |
19 | Remove MODULEs/SUBROUTINEs/FUNCTIONs within UKCA not called within the UM: SUBROUTINE asad_dealloc_chemdiag FUNCTION cd_findspeciesloc SUBROUTINE asad_lin_diagnostic MODULE asad_emissn_mod and SUBROUTINE asad_emissn FUNCTION prcount MODULE asad_inemit_mod and SUBROUTINE asad_inemit MODULE asad_inhet_mod and SUBROUTINE asad_inhet MODULE asad_inphot_mod and SUBROUTINE asad_inphot SUBROUTINE asad_mod_final MODULE asad_ycn_mod and SUBROUTINE asad_ycn MODULE quanto1d_mod and SUBROUTINE quanto1d SUBROUTINE activmkpdf MODULE ukca_fixedsb_mod and SUBROUTINE ukca_fixedsb SUBROUTINE deallocate_radaer_struct SUBROUTINE ukca_relax_ozone |
UM:#4512 | Not called within UM Need to decide whether any should be kept vn11.3_remove_redundant_UKCA_code |
DEPRECATED | Short-term | Alan J Hewitt |