Difference between revisions of "Minutes of the code management group meeting 2024-03-25"

Latest revision as of 16:20, 8 April 2024

Code management group minutes

Teleconference Details

Monday 25th March 2024, 10.00am - 11.30am GMT

Meeting via Zoom - details have been emailed

Met Office: MD, MS, AJH, JH

Cambridge: NLA

Leeds: MR, GM, DG

NIWA: OM

Canterbury:

CSIRO:

Apologies: FOC, AL, CH

Actions from this meeting

(ongoing) NLA to put C_SPECIES definitions in the Redundant Code table (short-term), and switch to use M_SPECIES instead. Talk with JH about AQUM tests and requirements. Note that there will be problems with exoplanets and >100km top configs where M_air not constant. NLA to make a branch and progress. May want to move to redundant code table at some point.
(ongoing) GM/DG to update table on UKCA wiki documenting GLOMAP versions. DG/GM to consider the code and lodging process for GLOMAP developments and consider a suitable rose-stem test supported by NLA.
(ongoing) JH on update API document to UMvn13.4 release. NLA to provide feedback before it is be circulated.
(ongoing) ALL look at um:#6203 showing other unprotected rose-stem options and think about any code/settings they are interested in.
(ongoing) NLA, AJH to identify owner for TropChem item in the Desirable changes not Tested Table. AJH to arrange call with NLA to discuss this and creation of rose-stem jobs. Should also update the UKCA UMDP to reflect which configurations are supported/widely used.
(new) ALL to consider ordering of the Progress with Priorities table and highlight things that should be higher priority, and any other tasks that need to be included.
(new) NLA to adjust the Priorities Table slightly before the UKCA Science and Management Board meeting on the 3rd May and email round to the CMG for comment.
(new) NLA to contact Jonny at NIWA regarding a Cylc 8 Box model configuration.
(new) NLA to add PSCs and thread safe work to Priorities table.
(new) MD to look at where to add photolysis API to Priorities table.
(new) NLA to update working practices to highlight the need to check pressure-level versions of new diagnostics added.
(new) NLA to tidy up redundant code table to take out people no longer working on UKCA.
(new) NLA to send round a Doodle Poll for early- to mid-May.

Actions from the Last Meeting (NLA)

Minutes of the code management group meeting 2024-01-15

(ongoing) NLA to put C_SPECIES definitions in the Redundant Code table (short-term), and switch to use M_SPECIES instead. Talk with JH about AQUM tests and requirements. Note that there will be problems with exoplanets and >100km top configs where M_air not constant. LA to make a branch and progress. May want to move to redundant code table at some point
- Ongoing
(ongoing) GM/DG to update table on UKCA wiki documenting GLOMAP versions. DG/GM to consider the code and lodging process for GLOMAP developments and consider a suitable rose-stem test supported by NLA.
- GM & DG have had a discussion with AJ in MO APP team and have been collecting code together to lodge back. There is also PSC code that is aiming to go on that adds STS.
- GM going down to Exeter in April and will try to establish a timeline and will start on newly released version.
(ongoing) JH on update API document to UMvn13.4 release. NLA to provide feedback before it is be circulated.
- Ongoing
(ongoing) ALL look at um:#6203 showing other unprotected rose-stem options and think about any code/settings they are interested in.
- Ongoing
(ongoing) NLA, AJH to identify owner for TropChem item in the Desirable changes not Tested Table. AJH to arrange call with NLA to discuss this and creation of rose-stem jobs. Should also update the UKCA UMDP to reflect which configurations are supported/widely used.
- Ongoing
(ongoing) DG and AJH to chat offline regarding bug #152 (correct bug in water_content_v)
- DG working on a ticket.
- Closed
(new) ALL to consider ordering of the Progress with Priorities table and highlight things that should be higher priority, and any other tasks that need to be included
- Ongoing
(new) DG to take ownership of Priority #2
- Closed.
- Now #14 in new table.
- ACTION: NLA to adjust the Priorities Table slightly before the UKCA Science and Management Board meeting on the 3rd May and email round to the CMG for comment
(new) NLA to remove the copy of the priorities table from future agendas, so we will instead use the linked table above
- Closed
(new) NLA to send round a Doodle poll for mid-late March
- Closed

Standing actions

(ongoing - standing item) CMG to monitor list of bugs and circulate between group for owners.
(ongoing - standing item) At CMG future meetings there should be included an appendix listing the open bugs. If a ticket is included it is not an open bug (as the owner of ticket is person doing lodging).
(ongoing - standing item) ALL with access to keep monitoring ukca_bugs email list.
(ongoing - standing item) ALL to think about if code changes will change KGO and let systems team know in good time, and remember to include the UKCA keywords to all UKCA tickets. This should be a standard part of our working practice. Note also the required keywords.
(ongoing - standing item) ALL to note, review, and remove obsolete/redundant code
(ongoing - standing item) ALL closed ticket owners to produce a summary of their change for the UKCA newsletter for special occasions, e.g. to coincide with Composition-Climate Meeting.
(ongoing - standing item) Code Owner to produce draft newsletter for CMG to approve.
(ongoing - standing item) ALL to consider other rose-stem tests that could be included.
(ongoing - standing item) ALL to email NLA with suggestions for next set of tutorials.

Tickets (NLA)

Tickets on MOSRS:

PLEASE REMEMBER TO USE THE UKCA KEYWORD FOR ALL UKCA CHANGES

NOTE: The UM requirement for LFric testing of all changes under UM:src/atmosphere, UKCA:src/science, and UKCA:src/control/core

Please also give any feedback on the UM release cycle to NLA to pass-back to UM Sys.

Message from UM Sys - please take care when considering keywords. It is important to get these correct for the Code Review process.

It was noted that the LFRic repository split will be happening soon into a core one and a science one. This should then be easier to develop for LFRic as usually only the science code will be changed.

ACTION: NLA to contact Jonny at NIWA regarding a Cylc 8 Box model configuration

Progress with Priorities (NLA)

ACTION REQUEST FROM UKCA SCIENCE & MANAGEMENT BOARD: CMG to provide list of priorities & their status, with particular thought to UKESM2 changes that will be required.

Progress with Priorities table

ACTION: NLA to add PSCs and thread safe work to Priorities table ACTION: MD to look at where to add photolysis API to Priorities table

Bugs/Bugfixes (NLA)

Open Bugs

#	Description	Ticket	Owner	Comments
124	H2 and N2 cannot be set for RCP and WMOA1 scenario routines	UM:#5620	Mohit Dalvi	Values are hard-wired in the code and cannot be changed without a branch Will be handled at UM11.8 At least for the next version Keep open Tested it quickly - N2 is used from namelist but not obvious, but H2 needs further testing
128	Bug in UKCA stratospheric chemistry diagnostics	UM:#5839	Luke Abraham	pre-UMvn10.0. The indexing/values of diagnostics m01s50i101-i104 are incorrect. Fixes provided for vn11.1 and vn11.7. May affect CMIP6 diagnostics May be best to lump #101. NLA to contact JM Should be fixed for UKESM2 Biggish ticket for 12.2 with bug fixes. See if can be done for 12.3 Nice to do ASAP, but if just diagnostics might be able to do at a later time.
143	Error in print statements from UKCA_TRACERS_COPY_FROM_UM			The final species listed in the diagnostic print statement seems to have very large concentrations (O(1E+08)) compared to others in the ppm-ppt range. Does not seem to affect model output. Reported by James Weber.
144	interchangeable use of specific humidity and water vapour mixing ratio	#6813		UKCA includes calculations of relative humidity, clear-sky relative humidity and saturation vapour pressure. Relative humidity calculations should be based on water vapour mass mixing ratio but are in part based on specific humidity. Also, the calculation of saturation vapour pressure is derived from saturation mixing ratio but uses a formula for deriving SVP from saturation specific humidity. This interchangeable use of specific humidity (ratio for moist air) and mixing ratio (ratio for dry air) in existing configurations introduces small numerical errors in UM and LFRic model runs. These bugs were identified at UM version vn12.2 and have been highlighted by comments in code lodged with UM ticket #6660 (in ukca_main1-ukca_main1.F90 and atmos_ukca_humidity_mod.F90). All UKCA configurations are affected. JH doesn’t think it’s complicated but not particularly trivial either.
145	all_ntp not explicitly dimensioned in UKCA_MAIN	Possible fix here		all_ntp not being dimensioned explicitly in ukca_main1-ukca_main1.F90. Highlighted in NCAS CMS ticket https://cms-helpdesk.ncas.ac.uk/t/nested-ukca-suite-on-archer2/604 raised by Paul Field. Grenville Lister has found the cause and implemented a possible fix https://code.metoffice.gov.uk/trac/um/changeset/110132/main/branches/dev/grenvillelister/vn12.0_all_ntp_fix
150	ukca_ddepctl bug for 27 tiles	ukca:#19		Will alter results of 27 tile ukesm1 runs. Fixed in Jules code by Garry, so no bug in UKESM2. Will affect any job where ice isn’t the last tile. Not that not all UKCA configurations use JULES - e.g. ACCESS May not fix in UKCA - will only fix in JULES repo. If it’s a small enough change, JM may sign off the fix. Will still be a while until CSIRO will use the latest UM versions. \|\| May not need a temporary logical.
152	correct bug in water_content_v	ukca:#130	Dan Grosvenor and Alan J Hewitt	The code appears to be different to the description in the text book Fundamentals of Atmospheric Modelling DG and AJH to chat offline regarding bug #152 (correct bug in water_content_v)

There was a reminder to check pressure-level versions of new diagnostics.

ACTION: NLA to update working practices to highlight the need to check pressure-level versions of new diagnostics added.

Redundant Code (NLA)

Code for deletion

PLEASE REMEMBER TO EDIT THE ORIGINAL REDUNDANT CODE TABLE AND NOT THIS PAGE

The NG-Composition Project Board has agreed to use the Redundant code table as the Technical Debt Log for UKCA as part of that project. This has highlighted the issue that some areas of code are not listed as being redundant, but are also not tested/used routinely and are not in any rose-stem tests, for example 2D photolysis and the TropIsop and Strat chemistry schemes. We have been asked to review this code and list untested code which is still desirable to be included for testing, and to ensure that other areas of code are listed for deletion.
It is noted that we may have more time to work on these once LFRic work is done, and most can't be retired as under rose-stem for GA7.

#	Description	Ticket	Remarks	Status	Timeframe	Owner	Comments from previous meetings
4	ukca_strat_update.F90 - relax_ozone	UM:#1505	None	PROPOSED	Medium-term	Luke Abraham
5	Backward Euler Standard Tropospheric Chemistry	UM:#1507	None	PROPOSED	Medium-term	Fiona O'Connor
6	Wet oxidation of SO2 in GLOMAP	UM:#4475	None	PROPOSED	Medium-term		JM to look at this re: UKESM1 c.f. offline GLOMAP. JM to take ownership. Still needed for CTM. Relevance for standalone code and later coupling to CTM.
7	Updraft velocity - l_conv_tke	UM:#3668	Proposed in December 2017. Approval being sought for GA series (likely GA8).	PROPOSED	Medium-term	Alan J Hewitt / Ian Boutle
8	All backward Euler chemistry schemes	None	Note that this is only for the “hard-coded” BE schemes. Quite a lot of work would be involved, but good as a longer-term aim. Note that problems for AQUM would need to be addressed first.	PROPOSED	Long-term	Luke Abraham
9	Deprecated UKCA netcdf attribute options	UM:#2513	'emission_type', string type attributes no longer recommeneded. Need some time for most new code to adopt these. Still used in AQUM files.	DEPRECATED	Medium-term		AQUM are addressing the files. Have gone from operational jobs, have ticket to remove from rose-stem. LN to document. These have been removed from AQUM. AQUM work has been done. From AS: In the ancil ticket linked from #2513 (https://code.metoffice.gov.uk/trac/ancil/ticket/782) it says that GA7 depends on the old format files, and as far as I know this is still true. In the 3-step timeline suggested, we haven't reached step 2 unfortunately. That ticket was about ensuring GA8 did not use the old attributes. I believe that GA8 is due for release in the next few months (it has been a very long time coming), so UM vn11.5 may be the last version at which GA7 is supported. Do you mind waiting a bit longer? AJH to follow-up with LA
10	ASAD families chemistry	None	Families chemistry has not been used for many years (since at least UM6.1. It is likely that it no longer works if turned on, and it complicates the code making other developments harder	DEPRECATED	Short-term	Luke Abraham
11	Dry deposition 9 PFT option	None	The 13 PFT option has been adopted for UKESM1. The 9 PFT option is possibly not being used at all. Proposed in June 2018.	PROPOSED	Long-term	Alan J Hewitt	AJH may be able to remove 9 PFT option, but it might be better to do when removing other dry-dep temporary logicals.
12	Remove explicit `C_SPECIES` constants and calculate these from `M_SPECIES` and the mass of air	None	Will have wide-ranging rose-stem KGO breakages	PROPOSED	Short-term	Luke Abraham
13	Remove temporary logical l_fix_nacl_density Introduced at UM:#2405	UM:#3490	Requires AMIP testing and a GMED ticket Could be accepted to GA9	PROPOSED	Medium-term	Jane Mulcahy	See JM GMED action
15	Remove temporary logical l_fix_ukca_impscav Introduced at UM:#1421	UM:#4145	Approval being sought for GA series (likely GA9) GMED:#402	PROPOSED	Medium-term	Alan J Hewitt	See JM GMED action
16	Remove temporary logical l_fix_improve_drydep Introduced at UM:#1250	UM:#3997	Approval being sought for GA series (likely GA9) GMED:#393	PROPOSED	Medium-term	Alan J Hewitt	See JM GMED action
17	Remove temporary logical l_fix_ukca_h2dd_x Introduced at UM:#4157	UM:#4245	Approval being sought for GA series (likely GA9) GMED:#410	PROPOSED	Medium-term	Alan J Hewitt	See JM GMED action
18	Remove temporary logical l_fix_neg_pvol_wat Introduced at UM:#4383	UM:#4416	Approval being sought for GA series (likely GA9) GMED:#421	PROPOSED	Medium-term	Alan J Hewitt
21	Remove code behind L_use_stratclim from ukca_fastjx_mod Introduced prior to MOSRS	UM:#4854	This could either be properly included via a namelist or removed from the UM	PROPOSED	Medium-term	Alan J Hewitt	LA contact OW about progressing FastJX-RADAER work Ties in with API work. MD/NC to take a look, can be removed. Do as part of API. Relevant person take ownership as part of API work NC to take ownership as part of his work
24	Remove ability to use of Cambridge 2D model data from ukca_stratf.F90			PROPOSED			Need to confirm from wider community for possible tropospheric configs and other choices for top-bdy
25	Change from using ukca_chem_master.F90 to a file-read for the chemical mechanism			PROPOSED	Short-term	Luke Abraham	Current chem_master module has compiler issues with that require changes to optimisation level on some compilers. A file read would be more flexible and would allow the mechanism to be more easily changed not requiring UM/UKCA code tickets.
26	highorder_scheme			PROPOSED		Mohit Dalvi	May need to test this in rose-stem
27	Stratospheric photolysis: Remove code for reading of JTABLE rates (calcjs_mod) and prescribed O3 ,temperature (initjtab_mod). The read methods do not seem to have ever been used in the UM as required values are required hardwired in respective modules. Necessary for Photolysis API and LFric porting			PROPOSED	Short term	Mohit Dalvi

ACTION: NLA to tidy up redundant code table to take out people no longer working on UKCA.

Desirable Science not tested

PLEASE REMEMBER TO EDIT THE ORIGINAL SCIENCE NOT TESTED TABLE AND NOT THIS PAGE

See also the complete list of unprotected rose-stem options

#	Description	Remarks	Owner
1	Use of tropospheric (2D) look-up table photolysis	Still useful to compare against FastJX. May be used for a "fast" configuration. Will be doen as part of photolysis refactoring
2	TropIsop chemistry configuration	May be useful in a "fast" configuration & to drive GLOMAP-mode. Useful for low-top configurations.
3	Strat chemistry configuration	Useful for stratospheric studies, particularly with a high model top.	Luke Abraham

Round (virtual) Table of current activities, plans

Person	Activity
MD	Working on Photolysis API

A.O.B. & D.N.M. (NLA)

Date of next meeting (NLA)

ACTION: NLA to send round a Doodle Poll for early- to mid-May.

@@ Line 7: / Line 7: @@
 '''Meeting via Zoom - details have been emailed'''
-'''Met Office:'''
+'''Met Office:''' MD, MS, AJH, JH
-'''Cambridge:'''
+'''Cambridge:''' NLA
-'''Leeds:'''
+'''Leeds:''' MR, GM, DG
-'''NIWA:'''
+'''NIWA:''' OM
 '''Canterbury:'''
@@ Line 19: / Line 19: @@
 '''CSIRO:'''
-'''Apologies:'''
+'''Apologies:''' FOC, AL, CH
 ==Actions from this meeting ==
+# (ongoing) NLA to put <code>C_SPECIES</code> definitions in the  ''Redundant Code'' table (short-term), and switch to use <code>M_SPECIES</code> instead. Talk with JH about AQUM tests and requirements. Note that there will be problems with exoplanets and >100km top configs where M_air not constant. NLA to make a branch and progress. May want to move to redundant code table at some point.
+# (ongoing) GM/DG to update table on UKCA wiki documenting [[GLOMAP versions]]. DG/GM to consider the code and lodging process for GLOMAP developments and consider a suitable rose-stem test supported by NLA.
+# (ongoing) JH on update API document to UMvn13.4 release. NLA to provide feedback before it is be circulated.
+# (ongoing) ALL look at [https://code.metoffice.gov.uk/trac/um/ticket/6203 um:#6203 showing other unprotected rose-stem options] and think about any code/settings they are interested in.
+# (ongoing) NLA, AJH to identify owner for TropChem item in the ''[[#Desirable_Science_not_tested|Desirable changes not Tested]]'' Table. AJH to arrange call with NLA to discuss this and creation of rose-stem jobs. Should also update the UKCA UMDP to reflect which configurations are supported/widely used.
+# (new) ALL to consider ordering of the [[Priorities|Progress with Priorities table]] and highlight things that should be higher priority, and any other tasks that need to be included.
+# (new) NLA to adjust the [[Priorities]] Table slightly before the UKCA Science and Management Board meeting on the 3rd May and email round to the CMG for comment.
+# (new) NLA to contact Jonny at NIWA regarding a Cylc 8 Box model configuration.
+# (new) NLA to add PSCs and thread safe work to [[Priorities]] table.
+# (new) MD to look at where to add photolysis API to [[Priorities]] table.
+# (new) NLA to update working practices to highlight the need to check pressure-level versions of new diagnostics added.
+# (new) NLA to tidy up redundant code table to take out people no longer working on UKCA.
+# (new) NLA to send round a Doodle Poll for early- to mid-May.
 == Actions from the Last Meeting (NLA) ==
@@ Line 29: / Line 42: @@
 # (ongoing) NLA to put <code>C_SPECIES</code> definitions in the  ''Redundant Code'' table (short-term), and switch to use <code>M_SPECIES</code> instead. Talk with JH about AQUM tests and requirements. Note that there will be problems with exoplanets and >100km top configs where M_air not constant. LA to make a branch and progress. May want to move to redundant code table at some point
+#* Ongoing
 # (ongoing) GM/DG to update table on UKCA wiki documenting [[GLOMAP versions]]. DG/GM to consider the code and lodging process for GLOMAP developments and consider a suitable rose-stem test supported by NLA.
+#* GM & DG have had a discussion with AJ in MO APP team and have been collecting code together to lodge back. There is also PSC code that is aiming to go on that adds STS.
+#* GM going down to Exeter in April and will try to establish a timeline and will start on newly released version.
 # (ongoing) JH on update API document to UMvn13.4 release. NLA to provide feedback before it is be circulated.
+#* Ongoing
 # (ongoing) ALL look at [https://code.metoffice.gov.uk/trac/um/ticket/6203 um:#6203 showing other unprotected rose-stem options] and think about any code/settings they are interested in.
+#* Ongoing
 # (ongoing) NLA, AJH to identify owner for TropChem item in the ''[[#Desirable_Science_not_tested|Desirable changes not Tested]]'' Table. AJH to arrange call with NLA to discuss this and creation of rose-stem jobs. Should also update the UKCA UMDP to reflect which configurations are supported/widely used.
+#* Ongoing
 # (ongoing) DG and AJH to chat offline regarding bug #152 (correct bug in water_content_v)
+#* DG working on a ticket.
+#* Closed
 # (new) ALL to consider ordering of the [[Priorities|Progress with Priorities table]] and highlight things that should be higher priority, and any other tasks that need to be included
+#* Ongoing
-# (new)DG to take ownership of Priority #2
+# (new) DG to take ownership of Priority #2
+#* Closed.
+#* Now #14 in new table.
+#* '''ACTION:''' NLA to adjust the [[Priorities]] Table slightly before the UKCA Science and Management Board meeting on the 3rd May and email round to the CMG for comment
 # (new) NLA to remove the copy of the priorities table from future agendas, so we will instead use the linked table above
+#* Closed
 # (new) NLA to send round a Doodle poll for mid-late March
+#* Closed
 === Standing actions ===
@@ Line 55: / Line 82: @@
 Tickets on MOSRS:
-* [https://code.metoffice.gov.uk/trac/um/query?status=approved&status=assigned&status=closed&status=code_review&status=committed&status=in_progress&status=new&status=sci%2Ftech_review&keywords=~UKCA&milestone=UMXX.Y+(Feb-24)&group=owner&col=id&col=summary&col=milestone&col=status&col=type&col=component&col=reporter&order=priority UM Tickets: ~February 2024 (UMXX.Y)]
+* [https://code.metoffice.gov.uk/trac/um/query?status=approved&status=assigned&status=closed&status=code_review&status=committed&status=in_progress&status=new&status=sci%2Ftech_review&keywords=~UKCA&milestone=UMXX.Y+(Feb-24)&group=owner&col=id&col=summary&col=milestone&col=status&col=type&col=component&col=reporter&order=priority UM Tickets: Feb-24 (UMXX.Y)]
 * [https://code.metoffice.gov.uk/trac/lfric/query?status=assigned&status=closed&status=code_review&status=committed&status=in_progress&status=new&status=ready_for_code_review&status=ready_for_science_review&status=science_review&keywords=~UKCA&milestone=Bianca+(February+2024)&group=owner&col=id&col=summary&col=milestone&col=status&col=owner&col=type&col=priority&col=component&order=priority LFRic Tickets: Bianca (February 2024)]
+* [https://code.metoffice.gov.uk/trac/lfric/query?status=assigned&status=closed&status=code_review&status=committed&status=in_progress&status=new&status=ready_for_code_review&status=ready_for_science_review&status=science_review&keywords=~UKCA&milestone=Fallow+Deer+(May+2018)&group=owner&col=id&col=summary&col=milestone&col=status&col=owner&col=type&col=priority&col=component&order=priority LFRic Tickets: Fallow Deer (May 2024)]
+* [https://code.metoffice.gov.uk/trac/lfric/query?status=assigned&status=closed&status=code_review&status=committed&status=in_progress&status=new&status=ready_for_code_review&status=ready_for_science_review&status=science_review&keywords=~UKCA&milestone=Grysbok+(August+2018)&group=owner&col=id&col=summary&col=milestone&col=status&col=owner&col=type&col=priority&col=component&order=priority LFRic Tickets: Grysbok (August 2024)]
 * [https://code.metoffice.gov.uk/trac/ukca/query?status=approved&status=assigned&status=closed&status=code_review&status=committed&status=in_progress&status=new&status=sci%2Ftech_review&milestone=UM+Spring+2024&group=owner&col=id&col=summary&col=milestone&col=status&col=owner&col=type&col=priority&col=time&order=priority UKCA Tickets: UM Spring 2024]
 * [https://code.metoffice.gov.uk/trac/ukca/query?status=approved&status=assigned&status=closed&status=code_review&status=committed&status=in_progress&status=new&status=sci%2Ftech_review&milestone=UM+Summer+2024&group=owner&col=id&col=summary&col=milestone&col=status&col=owner&col=type&col=priority&col=time&order=priority UKCA Tickets: UM Summer 2024]
@@ Line 69: / Line 98: @@
 ''Message from UM Sys - please take care when considering keywords. It is important to get these correct for the Code Review process.''
+It was noted that the LFRic repository split will be happening soon into a core one and a science one. This should then be easier to develop for LFRic as usually only the science code will be changed.
+'''ACTION:''' NLA to contact Jonny at NIWA regarding a Cylc 8 Box model configuration
 == Progress with Priorities (NLA) ==
@@ Line 74: / Line 107: @@
 '''ACTION REQUEST FROM UKCA SCIENCE & MANAGEMENT BOARD:''' CMG to provide list of priorities & their status, with particular thought to UKESM2 changes that will be required.
+'''[[Priorities|Progress with Priorities table]]'''
-'''PLEASE REMEMBER TO EDIT THE ORIGINAL TABLE AND NOT THIS PAGE'''
+'''ACTION:''' NLA to add PSCs and thread safe work to [[Priorities]] table
-=== [[Priorities|Progress with Priorities table]] ===
+'''ACTION:''' MD to look at where to add photolysis API to [[Priorities]] table
-'''ACTION:''' ALL to consider ordering of the [[Priorities|Progress with Priorities table]] and highlight things that should be higher priority, and any other tasks that need to be included
-'''ACTION:''' DG to take ownership of Priority #2
-'''ACTION:''' NLA to remove the copy of the priorities table from future agendas, so we will instead use the linked table above
-==== Progress with open priorities and notes from this meeting (NLA) ====
-The current priorities are:
-{| class="wikitable" border = "1px"
-!style="text-align:top;rowspan:2";|#
-!style="text-align:top;rowspan:2";|Description
-!style="text-align:top;rowspan:2";|Owner
-!style="text-align:top;rowspan:2";|Desirable for UKESM2?
-!style="text-align:top;rowspan:2";|Status
-!style="text-align:top;rowspan:2";|Comments from this meeting
-!style="text-align:top;rowspan:2";|Complete
-|-
-|1 || Review UKCA tests to cover all requirements || Luke Abraham / Mohit Dalvi || No || Will cover these in a table in future for review. <br/> Updated testing coverage on Linux and can run 1x1 decomposition ||  ||
-|-
-|2 || Updates/fixes to GLOMAP routines || maybe Anthony Jones (main) <br/> Graham <br/> Sandip  || No || Graham and Sandip developed updates for stratospheric aerosol on old branch <br/> It is desirable to include this to the trunk at some point <br/> November 23 - we clarified what this priority was Graham and Sandip developed updates for stratospheric aerosol on old branch <br/> It is desirable to include this to the trunk at some point <br/> (originally owned by Adrian Hill) ||   ||
-|-
-|3 || Standalone UKCA configurations || Luke Abraham/Scott Archer-Nicholls || No || ExCALIBUR work progressing.<br/> Aim to remove UKCA from UM trunk at vn12.3. <br/> See [[Box_model|UKCA Box Model]] page || ||
-|-
-|4 || Emissions flexibility || probably Mohit Dalvi??? || No || (a) <br/> Modify ‘ukca_set_emissions’ to handle data for 1D domains (for consistency with
-ukca_set_environment). <br/> (b) <br/>  Improve interface for registration of aerosol emissions by avoiding the need for parent to know
-the number of entries required for each emission in the internal data structure. <br/> (c) <br/> Improve handling of vertical scaling factors to reduce redundancy. <br/> [Desirable on technical grounds: (a), (b) and potentially (c) will remove unnecessary complexity for parents. (b) will require linked tickets for compatibility so becomes harder to do later if used by more parents. Vertical scaling factors are 3D fields, often all 0 apart from surface - cannot persist internally between time steps in LFRic/NAME and must be regenerated or handled by parent, so scope for efficiency savings with (c).]
- ||  ||
-|-
-|5 || RADAER API || Alan Hewitt (main) || No || Radaer API on hold until after GA7 port to LFRic. <br/> Functionality of RADAER in LFRic will work without an API although it will be preferable to update this in future. <br/> Not clear if RADAER will work independently of UM in single column mode. <br/> AJH and AJ and JH and Ben Johnson and NB need to work out if desirable and practical to run independent of UM. || ||
-|-
-|6 || RADAER optimisation <br/> emulation  || Alan Hewitt (main) <br/> Ben Johnson || NO || AJH highlighted that there have been some discussions about this - a few people interested in this (James Manners, AJ, Ben Johnson, AJH). <br/> AJH and others to look at emulation of RADAER  ||  ||
-|-
-|7 || RADAER optimisation <br/> integration points || Alan Hewitt <br/> Ben Johnson (main) || NO || Have had someone looking to see if something could be changed to make it faster to make a trimmed-down version with less calculations for e.g. NWP. <br/> AJH and BJ to look at making number of integration points a user variable <br/> AJH has functionality to do 1 integration point now. BJ is going to lead this one and see what happens when run with this for use in a weather context. Would give a ~4x speed-up for RADAER. ||  ||
-|-
-|8 || FastJX-GLOMAP coupling || TBC <br/> Ticket owned by Fiona || YES <br/> '''but it didnt make it''' || UMvn10.8 branches exist - see ticket [https://code.metoffice.gov.uk/trac/um/ticket/2689 UM:#2689]<br/>'''Note:''' FastJX rates also need updating - potential for code as well as input-file changes || ||
-|-
-|9 || Cloud-J || TBC || No || || ||
-|-
-|10 || UKCA STASHmaster PP-codes || Luke Abraham || No || Verification system makes some use of existing PP-codes. '''New items should have a PP-code of 0''' and verification team will use STASH items for these if required. || ||
-|-
-|11 || Removal of redundant code || ALL || No || Parked whilst GA7.0 is a protected suite. || ||
-|-
-|12 || GLOMAP-CLIM API refresh || Alan J Hewitt || No || Cuurently parked. <br/> Extend API to include GLOMAP-clim within the core UKCA code (or alternatively provide UKCA routines required by GLOMAP-clim in the UKCA API). Required to avoid the need to by-pass the API.|| ||
-|-
-|13 || N48L85 configuration || TBC || No || ||
-|-
-|14 || ACTIVATE optimisation || TBC || No || A quick win here is to reduce nwbins in namelist ( see um:#4740 ). <br/> Parked for now. <br/>  There does not seem to be resource to look at this at present.<br/> This could be tested for UKESM-fast. Another potential change would be to alter the call to only when there are clouds || ||
-|-
-|15 || Stratospheric Ozone improvements || James Keeble/Luke Abraham || YES<br/>[https://code.metoffice.gov.uk/trac/UKESM/ticket/729 UKESM:#729] || Work ongoing, covered in ticket [https://code.metoffice.gov.uk/trac/um/ticket/5641 UM:#5641]. <br/>'''Note:''' FastJX rates also need updating - potential for code as well as input-file changes <br/> See also [https://code.metoffice.gov.uk/trac/UKESM/ticket/841 UKESM:#841] for UKCA package ticket || || YES
-|-
-|16 || Glomap aerosol and GPU || Alan J Hewitt (main) <br/> Joe Abram || No || Started at vn13.3 || ||
-|-
-|17 || Photolosis and GPU || Joe Wallwork <br/> Joe Abram  || No ||  || ||
-|-
-|18 || ASAD Chemistry solver and GPU || Joe Wallwork  || No || Nov 23 - Working with PsyClone for this, as itdoes most of the directives. ||  ||
-|-
-|19 || Support for UM hybrid resolution model and provision of internal variables via the API || Mark Stringer (main) || No || Required to avoid the need to by-pass the API. <br/> Currently a low priority task. <br/> Code is protected by rose-stem so do not need to fix this urgently. <br/> Nov 23 -  MS has little time to work on this at present. An edge case for API usage. || ||
-|-
-|20 || Removal of unnecessary UM module dependencies in LFRic builds || Richard Gilham (main)  || No || LFRic currently uses the UM version of ukca_um_legacy_mod which is dependent on a large number of modules (e.g. STASH system modules) that are not required. <br/> In principle, this could be fixed by an LFRic version of ukca_um_legacy_mo. <br/>  Rich has been looking at an alternative method using compiler directives (see Ticket ukca:#123 Purge usage of copydiag and friends for non-UM use cases). <br/> [Essential: Remaining dependencies on a large number of unused modules (e.g. STASH etc.) are impacting on efficiency of LFRic build.] || ||
-|-
-|21 || Removal of remaining UM module dependencies in non-UM/LFRic builds || John Hemmings || No || This will allow UKCA to be built with no UM repository modules (7 are currently needed). Unassigned ticket UKCA:#28 covers most of the required work. <br/> [Essential: It must be possible to use UKCA without access to the UM repository.] || ||
-|-
-|22 || Reworking of internal data flow for API-level multi-thread capability || TBC || No || Covered by unassigned ticket UKCA:#30. <br/> [High priority for both LFRic and NAME: Needed a.s.a.p. to achieve the required performance but expected to be a big job]. ||  ||
-|-
-|23 || Removal of photolysis support code || TBC || No || Photolysis still relies on UKCA to determine its environmental driver requirements. Covered by unassigned ticket UKCA:#79. Needs to be coordinated with photolysis API development. <br/> [Essential: Until this is done, photolysis cannot be run independently of UKCA and the need to retain support for photolysis adds unnecessary complexity to UKCA.] ||  ||
-|-
-|24 || Handling of solar calculations and time inputs || TBC || No || Covered by unassigned tickets UKCA:#27 and UKCA:#92. Ticket #27 addresses inconsistencies between calculations for offline oxidants and isoprene and the potential for inconsistency with photolysis as well as avoiding the need for a 'previous_time' input. <br/> [Desirable on scientific and technical grounds: Current redundancy in required inputs adds unnecessary complexity for parent models and there is significant scope for efficiency improvements and internal simplification.] ||  ||
-|-
-|25 || New error handling method || John Hemmings || No || (a) <br/> Replace error handling in API routines with new method using 'error_report' (see Ticket UKCA:#29). <br/> (b) <br/> Replace all 'ereport' calls with 'error_report' and add support for optional return of control to parent. <br/> [Desirable on technical grounds: Current inconsistencies are confusing and make code over complex. (a) is therefore relatively high priority. Return-control-to-parent functionality to be completed by (b) is lower priority but is desirable for anticipated large ensemble runs (to avoid having to abandon the whole ensemble on failure).] ||  ||
-|-
-|26 || Replace/remove UM legacy code in UKCA (where possible) || TBC || No || Includes UM humidity calculations, grid-specific aspects of volcanic SO2 and mass calculations, surface area calculation for heterogeneous chemistry on CLASSIC aerosols. May include ozone column calculation which is also used by photolysis (can be provided as a parent callback routine to act on post chemistry ozone). <br/> [Desirable on technical grounds: Current code is over complex, by-passes the API (thus restricting UKCA development) and is difficult to maintain.] ||  ||
-|-
-|27 || UKCA API user guide || John Hemmings (main) || No || This needs to include comprehensive instructions for setting up UKCA from scratch, independently from the UM, in a new parent application. <br/> [Essential.] ||  ||
-|-
-|}
 == Bugs/Bugfixes (NLA) ==
@@ Line 171: / Line 127: @@
 |-
 | 128 || Bug in UKCA stratospheric chemistry diagnostics || [https://code.metoffice.gov.uk/trac/um/ticket/5839 UM:#5839] || '''Luke Abraham''' || pre-UMvn10.0. The indexing/values of diagnostics m01s50i101-i104 are incorrect. Fixes provided for vn11.1 and vn11.7. May affect CMIP6 diagnostics <br/> May be best to lump #101. <br/> NLA to contact JM <br/> Should be fixed for UKESM2 <br/> Biggish ticket for 12.2 with bug fixes. <br/> See if can be done for 12.3 <br/> Nice to do ASAP, but if just diagnostics might be able to do at a later time. ||
-|-
-|| 136 || There appears to be a bug in some Section 51 diagnostics. || [https://code.metoffice.gov.uk/trac/um/ticket/6598 6598] ||  || 51996 and 51999 are fine. <br/> 51921 and 51922 are broken. <br/> Other fields unknown. <br/> Problem uncovered during [https://code.metoffice.gov.uk/trac/um/ticket/6358 6358] <br/> May just linger. Should we take the broken ones out? <br/> MD has opened a ticket to see which ones fail and which ones work <br/> MD has tested, some things came up, need to be re-tested again. <br/> Fixed code/ STASHmaster to be able to produce All P-level diagnostics from Strattrop and CRI-Strat at UM13.3 (except those from #147 below). Will attempt to lodge fixes for UM-Feb-24 release. || MD working on this, may make next release.
-|-
-|| 140 || Heaviside Function cannot have multiple level sets || [https://code.metoffice.gov.uk/trac/um/ticket/6816 um:#6816] || || The ''Heaviside function'' needed to scale UKCA pressure-level diagnostics is valid only for a single set of pressure levels from Stash requests. If some Sec 51/52 diagnostics are requested on say 19 pressure-levels and the same/ different ones on 36 pressure-levels, the Heaviside field in output will be applicable to only one of these. <br/> May be able to request multiple Heaviside functions <br/> The UM is able to do this for other Heaviside functions for climate diagnostics.  <br/> Checked at UM13.3; a separate copy of Heaviside can be produced for each set of pressure levels (Stash collates all the level sets into a single array for calculation before re-distributing for diagnostic write.) || MD working on this, may make next release.
 |-
 || 143 || Error in print statements from UKCA_TRACERS_COPY_FROM_UM || || || The final species listed in the diagnostic print statement seems to have very large concentrations (O(1E+08)) compared to others in the ppm-ppt range. Does not seem to affect model output. Reported by James Weber. ||
@@ Line 181: / Line 133: @@
 |-
 || 145 || all_ntp not explicitly dimensioned in UKCA_MAIN || Possible fix [https://code.metoffice.gov.uk/trac/um/changeset/110132/main/branches/dev/grenvillelister/vn12.0_all_ntp_fix here] ||  || all_ntp not being dimensioned explicitly in ukca_main1-ukca_main1.F90. Highlighted in NCAS CMS ticket <br/> https://cms-helpdesk.ncas.ac.uk/t/nested-ukca-suite-on-archer2/604 <br/> raised by Paul Field. Grenville Lister has found the cause and implemented a possible fix <br/> https://code.metoffice.gov.uk/trac/um/changeset/110132/main/branches/dev/grenvillelister/vn12.0_all_ntp_fix ||
-|-
-|| 147 || Missing products in Sec-50 diagnostics: Mismatch in ''ukca_chem_master'' and ''asad_flux_dat''<br/>'''50-092 STRATOSPHERIC OH LOSS''' (B153) Products for (OH + H2) changed under scheme v121 but not reflected in ''asad_flux_dat'' <br/>'''50-123 STRAT O3 LOSS: HO2 + NO3''' (B61) Product ''O2'' not available for StratTrop <br/> After chem v121/ always || || '''Luke Abraham''' || NLA to take a look || MD working on this, may make next release.
-|-
-|| 149 || CRI-Strat photolysis bug || [https://code.metoffice.gov.uk/trac/ukca/ticket/29 ukca:#29] <br/> [https://code.metoffice.gov.uk/trac/um/ticket/7205 um:#7205] || '''John Hemmings''' || There is a bug that causes the wrong photolysis rate field to be output for the JNO2 diagnostic when using the CRISTRAT scheme. This results from an indexing problem in photol_diags in ukca_um_photol_ctl_mod.F90 (UM vn13.2) causing the wrong photolysis rate field to be output.<br/>In lines 641-667, the loop used to find the index for accessing the required field data in ‘photol_rates’ relies on finding the position of the ‘jno2’ label in the ratj_varnames array and does not stop searching until the end of the array. In the CRISTRAT scheme there are multiple ‘jno2’ labels with different quantum yields and only one (with yield = 100%) is the correct one for the NO2 reaction. The others are for different reactions whose rates are derived from that. The index selected will be the last of the ‘jno2’ entries which is for the wrong reaction when there are multiple entries. The same processing is used for other photolysis rate labels but I don’t think these have multiple entries.<br/> The ratj_varnames array referred to above is returned by a call to the ukca_get_photol_reaction_data API routine (dummy argument varnames_ptr). It holds the fname component of the ratj_defs structure for each photolysis reaction in the chemistry scheme. The inline documentation for this routine in ukca_chem_defs_mod.F90 does not indicate that the list returned may contain duplicates. This should be made clear to reduce the risk of misuse in future.<br/> The bug will be corrected by UKCA:#29 and linked UM ticket #7205. These tickets will remove the existing UM-side code for the photolysis rate diagnostics and replace it with code using the new UKCA diagnostic handling scheme. This will access jrates after their input to UKCA as environmental driver data not before and it uses a more robust method to index the correct fields. || Can be closed.
 |-
 || 150 || ukca_ddepctl bug for 27 tiles || [https://code.metoffice.gov.uk/trac/ukca/ticket/19 ukca:#19] ||  || Will alter results of 27 tile ukesm1 runs. <br/> Fixed in Jules code by Garry, so no bug in UKESM2. <br/> Will affect any job where ice isn’t the last tile.<br/> Not that not all UKCA configurations use JULES - e.g. ACCESS <br/> May not fix in UKCA - will only fix in JULES repo.
 If it’s a small enough change, JM may sign off the fix. Will still be a while until CSIRO will use the latest UM versions. || May not need a temporary logical.
-|-
-|| 151 || minor UM depdency bug || [https://code.metoffice.gov.uk/trac/ukca/ticket/29 ukca:#29] || || A minor dependency bug in ukca_emiss_diags_mode_mod.F90 was introduced by [https://code.metoffice.gov.uk/trac/ukca/ticket/34 Ticket #34] where the copydiag routine is used directly from the UM module copydiag_mod. This means that at um13.3 an extra UM module is required to build UKCA outside the UM e.g. when coupling with NAME. Instead, the routine should be used from the module `ukca_um_legacy_mod` allowing it to be replaced with a stub in non-UM builds. || Can be closed.
 |-
 || 152 || correct bug in water_content_v || [https://code.metoffice.gov.uk/trac/ukca/ticket/130 ukca:#130] || Dan Grosvenor <br/> and <br/> Alan J Hewitt || The code appears to be different to the description in the text book <br/> Fundamentals of Atmospheric Modelling <br/> DG and AJH to chat offline regarding bug #152 (correct bug in water_content_v) ||
 |-
 |}
+There was a reminder to check pressure-level versions of new diagnostics.
+'''ACTION:''' NLA to update working practices to highlight the need to check pressure-level versions of new diagnostics added.
 == [[Redundant code|Redundant Code]] (NLA) ==
@@ Line 219: / Line 169: @@
 | 5 || Backward Euler Standard Tropospheric Chemistry || [https://code.metoffice.gov.uk/trac/um/ticket/1507 UM:#1507] || None || '''PROPOSED''' || Medium-term || Fiona O'Connor || ||
 |-
-| 6 || Wet oxidation of SO2 in GLOMAP || [https://code.metoffice.gov.uk/trac/um/ticket/4475 UM:#4475] || None || '''PROPOSED''' || Medium-term || Colin Johnson || JM to look at this re: UKESM1 c.f. offline GLOMAP. JM to take ownership. <br/> Still needed for CTM. Relevance for standalone code and later coupling to CTM. ||
+| 6 || Wet oxidation of SO2 in GLOMAP || [https://code.metoffice.gov.uk/trac/um/ticket/4475 UM:#4475] || None || '''PROPOSED''' || Medium-term || || JM to look at this re: UKESM1 c.f. offline GLOMAP. JM to take ownership. <br/> Still needed for CTM. Relevance for standalone code and later coupling to CTM. ||
 |-
 | 7 || Updraft velocity - l_conv_tke || [https://code.metoffice.gov.uk/trac/um/ticket/3668 UM:#3668] || Proposed in December 2017. Approval being sought for GA series (likely GA8). || '''PROPOSED''' || Medium-term || Alan J Hewitt / Ian Boutle ||  ||
@@ Line 225: / Line 175: @@
 | 8 || All backward Euler chemistry schemes ||  None || Note that this is only for the “hard-coded” BE schemes. Quite a lot of work would be involved, but good as a longer-term aim. ''Note'' that problems for AQUM would need to be addressed first. || '''PROPOSED''' || Long-term || Luke Abraham ||  ||
 |-
-| 9 || Deprecated UKCA netcdf attribute options || [https://code.metoffice.gov.uk/trac/um/ticket/2513 UM:#2513] || 'emission_type', string type attributes no longer recommeneded. Need some time for most new code to adopt these. Still used in AQUM files. || '''DEPRECATED''' || Medium-term || Nick Savage || AQUM are addressing the files. Have gone from operational jobs, have ticket to remove from rose-stem. LN to document. These have been removed from AQUM.<br/>AQUM work has been done. <br/> From AS: ''In the ancil ticket linked from #2513 (https://code.metoffice.gov.uk/trac/ancil/ticket/782) it says that GA7 depends on the old format files, and as far as I know this is still true. In the 3-step timeline suggested, we haven't reached step 2 unfortunately. That ticket was about ensuring GA8 did not use the old attributes. I believe that GA8 is due for release in the next few months (it has been a very long time coming), so UM vn11.5 may be the last version at which GA7 is supported. Do you mind waiting a bit longer?'' <br/> AJH to follow-up with LA ||
+| 9 || Deprecated UKCA netcdf attribute options || [https://code.metoffice.gov.uk/trac/um/ticket/2513 UM:#2513] || 'emission_type', string type attributes no longer recommeneded. Need some time for most new code to adopt these. Still used in AQUM files. || '''DEPRECATED''' || Medium-term || || AQUM are addressing the files. Have gone from operational jobs, have ticket to remove from rose-stem. LN to document. These have been removed from AQUM.<br/>AQUM work has been done. <br/> From AS: ''In the ancil ticket linked from #2513 (https://code.metoffice.gov.uk/trac/ancil/ticket/782) it says that GA7 depends on the old format files, and as far as I know this is still true. In the 3-step timeline suggested, we haven't reached step 2 unfortunately. That ticket was about ensuring GA8 did not use the old attributes. I believe that GA8 is due for release in the next few months (it has been a very long time coming), so UM vn11.5 may be the last version at which GA7 is supported. Do you mind waiting a bit longer?'' <br/> AJH to follow-up with LA ||
 |-
 | 10 || ASAD families chemistry || None || Families chemistry has not been used for many years (since at least UM6.1. It is likely that it no longer works if turned on, and it complicates the code making other developments harder || '''DEPRECATED''' || Short-term || Luke Abraham || ||
@@ Line 245: / Line 195: @@
 | 21 || Remove code behind L_use_stratclim from ukca_fastjx_mod <br/> Introduced prior to MOSRS || [https://code.metoffice.gov.uk/trac/um/ticket/4854 UM:#4854] || This could either be properly included via a namelist or removed from the UM || '''PROPOSED''' || Medium-term || Alan J Hewitt || LA contact OW about progressing FastJX-RADAER work <br/> Ties in with API work. MD/NC to take a look, can be removed. Do as part of API. <br/> Relevant person take ownership as part of API work <br/> NC to take ownership as part of his work ||
 |-
-| 24 || Remove ability to use of Cambridge 2D model data from ukca_stratf.F90 || ||  || '''PROPOSED''' || || Neal Carr || Need to confirm from wider community for possible tropospheric configs and other choices for top-bdy ||
+| 24 || Remove ability to use of Cambridge 2D model data from ukca_stratf.F90 || ||  || '''PROPOSED''' || ||  || Need to confirm from wider community for possible tropospheric configs and other choices for top-bdy ||
 |-
 | 25 || Change from using ukca_chem_master.F90 to a file-read for the chemical mechanism || ||  || '''PROPOSED''' || Short-term || Luke Abraham || Current chem_master module has compiler issues with that require changes to optimisation level on some compilers. A file read would be more flexible and would allow the mechanism to be more easily changed not requiring UM/UKCA code tickets. ||
@@ Line 255: / Line 205: @@
 |}
+'''ACTION:''' NLA to tidy up redundant code table to take out people no longer working on UKCA.
-It was noted that we may be able to remove some temp logicals as they are turned on in UKESM1.1 (and all other tests).
-AJH may be able to remove 9PFT (13 tile) deposition options soon.
 === Desirable Science not tested ===
@@ Line 286: / Line 234: @@
 !style="text-align:top;rowspan:2";|Activity
 |-
+|| MD || Working on Photolysis API
-|| ||
 |-
 |}
 == A.O.B. & D.N.M. (NLA) ==
-There was a discussion around the current PSC scheme, and NLA and GM should have a further conversation about this.
 == Date of next meeting (NLA) ==
-'''ACTION:''' NLA to send round a Doodle poll for mid-late March
+'''ACTION:''' NLA to send round a Doodle Poll for early- to mid-May.