Minutes of the code management group meeting 2019-09-16

From UKCA
Revision as of 14:41, 12 September 2019 by Marc (talk | contribs) (→‎Open Bugs)

Code management group minutes

Teleconference Details

Monday 16th September 2019, 10am - 11.30am GMT

  • UK Landline: +44 (0)1223 761376 (x61376 from an internal University of Cambridge phone)
  • Participant PIN: 735112

Present

Met Office:

Cambridge:

Leeds:

Reading:

Lancaster:

Edinburgh:

UEA:

NIWA:

CSIRO:

Apologies:

Actions from this meeting

Minutes

Actions from the Last Meeting (LA)

Minutes of the code management group meeting 2019-06-13

  1. (ongoing) LA to put C_SPECIES definitions in the Redundant Code table (short-term), and switch to use M_SPECIES instead. Talk with JH about AQUM tests and requirements. Note that there will be problems with exoplanets and >100km top configs where M_air not constant. LA to make a branch and progress for vn11.6.
  2. (ongoing) LA check MD's script for perpetual nudging.
  3. (ongoing) LA to create Wiki page on UKCA website for users to add details of configurations and input files.
  4. (new) LA to add All Pages link on UKCA Wiki
  5. (ongoing) LA to discuss with Leeds plans for a separate repository.
    • Videoconference held on 2019-06-24
  6. (ongoing) FOC to see what action can be taken from MASS, then put out an email for POCs from institutes. FOC/AH/MD to develop a strategy on MASS for discussion at next CMG as a data clear-out is required.
  7. (ongoing) JM to find someone to progress ticket/bugfix for SO2 deposition. Will need to be on a switch for UKESM1
  8. (ongoing) LA to contact AS/AJH and ask how best to proceed with removing the depreciated NetCDF attribute options.
  9. (ongoing) FOC to encourage Garry Hayman to start lodging JULES code piecemeal.
  10. (ongoing) ALL to read API document and look through new API code and send comments to JH
  11. (ongoing) LA to email GM and ask how GLOMAP would differ from how it is in other models (e.g. CTM, IFS etc.)
  12. (ongoing) LA to send priorities list to UKCA SMG
    1. UKCA API
    2. Review UKCA tests to cover all requirements
    3. Fix for c_h2o in Offline-Oxidants (bug #107)
    4. Updates/fixes to GLOMAP routines
    5. Standalone UKCA configurations
    6. Emissions flexibility
    7. Separare UKCA repository
    8. ACTIVATE optimisation
    9. FastJX-GLOMAP coupling
    10. Cloud-J
    11. Fixes for chemistry rates and ASAD (bugs #101 & #103)
    12. Rc fixes for water (bug #104)
    13. CH4 deposition fixes (bug #109)
    14. UKCA STASHmaster PP-codes
    15. Removal of redundant code
    16. GLOMAP-CLIM API refresh
    17. N48L85 configuration
  13. (new) Those with access check ukca_bugs regularly via OWA until Outlook access is fixed.
  14. (new) LA to take ownership of bug #107
  15. (new) LA to contact MH/OW regarding FastJX-GLOMAP coupling
    • Ongoing email discussions. Last from MH on 2019-06-19: "Thanks for the update on getting the FAST-JX GLOMAP coupling into the code. I will try my best to get it into the trunk at version 11.6. I might take you up on your kind offer to help with the tests when needed if that is ok?"
  16. (new) MD to update um_ukca_eg app to be more in line with UKESM1, and add a rigorous test
  17. (new) LA to add N48 Linux and update EXP test
  18. (new) ALL to consider other rose-stem tests that could be included
  19. (new) LA to check-in with Rich Gilham after the Code Freeze regarding SC0138 keyword
    • Discussed at UMPB July 2019: General discussion if the SC0138 keyword is really necessary and if replacing it with an appropriate collab keyword. Final verdict: Time to stop using it (SC0138 keyword).
  20. (new) ALL to email LA with suggestions for next set of tutorials
  21. (new) LA to send Doodle poll for early September.

Standing actions

  1. (ongoing - standing item) CMG to monitor list of bugs and circulate between group for owners.
  2. (ongoing - standing item) At CMG future meetings there should be included an appendix listing the open bugs. If a ticket is included it is not an open bug (as the owner of ticket is person doing lodging).
  3. (ongoing - standing item) ALL with access to keep monitoring ukca_bugs email list.
  4. (ongoing - standing item) ALL to think about if code changes will change KGO and let systems team know in good time, and remember to include the UKCA & SC0138 keywords to all UKCA tickets. This should be a standard part of our working practice. Note also the required keywords.
  5. (ongoing - standing item) ALL to note, review, and remove obsolete/redundant code
  6. (ongoing - standing item) ALL closed ticket owners to produce a summary of their change for the UKCA newsletter for special occasions, e.g. to coincide with Composition-Climate Meeting.
  7. (ongoing - standing item) Code Owner to produce draft newsletter for CMG to approve.

Bugs/Bugfixes (LA)

Open Bugs

# Description Ticket Owner Comments Comments from this meeting
35 Error in labelling: Surface resistance <--> stomatal resistance ? UM:#1409 Fiona O'Connor Leave open. Garry Hayman started work in offline JULES.
Still ongoing. JM found bug in SO2 deposition, where there is an inconsistency when changing tiles. Making progress.
Leave open. GH gave update, has done a lot of work. Concerned it might not be bit-reproducable, but could be solvable. Encouraging to lodge existing. Resistances done as metadata. Not clear as to timescales.
FOC to encourage Garry Hayman to start lodging JULES code piecemeal.
101 Errors in reaction rates and diagnostics UM:#4466 Luke Abraham / Scott Archer-Nicolls There is a need to conserve science config for UKESM1, so changes need to be on a flag.
Colin has been looking at DMSO, as this is not currently used in StratTrop but is in Offline.
Might be able to merge the rate with CEJ changes, but best to leave the diagnostic issues as a separate change.
LA, JM, CEJ, SAN to discuss offline and keep GM in loop.
Use versioning system. Talk about further offline.
Keep ongoing.
LA to do with #103
103 Incorrect indexing of tmprc array: ASAD_SPIMPMJP UM:#4562 Scott Archer-Nicolls Breaks KGO - affects solver convergence. In practice doesn’t make a huge difference, but should go into vn11.4, but does change KGO. UKESM1 - small change might be OK - get in touch for advice - might be able to test with UKESM1 AMIP only. Check with Oliver Wild
Could be rolled-up with #101
LA to do with #101
104 Incorrect value for Rc for SO_2 deposition to open water UM:#4635 Catherine Hardacre Got to be separate to #35, unless there is an idea of timelines.
JM to find someone to progress bug #104.
107 Missing c_h2o conversion factor in offline_oxidants_be um:#4714
um:#5118
Luke Abraham Code is zq(:)=RESHAPE(q(:,:,k),(/theta_field_size/)) rather than zq(:) = RESHAPE(q(:,:,k),(/theta_field_size/))/c_h2o
LA to take ownership and assess
108 Incorrect stash processing of GLOMAP load*, conc* and plume_scav diagnostics UM:#4909 Mohit Dalvi To be Lodged after 10.6
Do after CMIP6 runs are finished (after Jan 2020)
109 Bug in dry deposition of CH4 for 13/17/27 tiles UM:#4913 Gerd Folberth To be Lodged after 10.6
Gerd noted unusual CH4 output in CMIP6 runs.
May need a rose stem test for H2 and CH4 drdydep code lodged at UM:#4157
Makes a huge difference to CH4. Needs testing. AJH or GF will do during vn11.4, progress for vn11.6. May need UKESM1 approval.
110 UKCA solar-cycle routine does not pass NRUN-CRUN test UM:#4828 Luke Abraham To be Lodged after 11.5
111 Cloud fraction array (cloud_frac) passed with wrong number of levels
Array passed as (row_length, rows, :), so offset by 1 level under ENDGame
Part of UM:#4822 John Hemmings Affects all ENDGame versions. To be Lodged for 11.5
112 delh2so4_chem is calculated incorrectly UM:#5076 Luke Abraham To be Lodged for 11.6.
Incorrectly "fixed" in UM:#3245 (Bug #87).
All StratTrop+GLOMAP versions post vn8.2. Made worse post-vn11.4 if logical l_fix_ukca_h2so4_ystore is True.
113 Latitude bugs affecting LAM configurations UM:#5119 John Hemmings To be lodged for 11.6

Redundant Code (LA)

Code for deletion

PLEASE REMEMBER TO EDIT THE ORIGINAL REDUNDANT CODE TABLE AND NOT THIS PAGE

# Description Ticket Remarks Status Timeframe Owner Comments from previous meetings Comments from this meeting
2 Old dry deposition scheme UM:#2356 None PROPOSED Medium-term Nick Savage
4 ukca_strat_update.F90 - relax_ozone UM:#1505 None PROPOSED Medium-term Luke Abraham
5 Backward Euler Standard Tropospheric Chemistry UM:#1507 None PROPOSED Medium-term Fiona O'Connor
6 Wet oxidation of SO2 in GLOMAP UM:#4475 None PROPOSED Medium-term Colin Johnson JM to look at this re: UKESM1 c.f. offline GLOMAP. JM to take ownership.
7 Updraft velocity - l_conv_tke UM:#3668 Proposed in December 2017. Approval being sought for GA series (likely GA8). PROPOSED Medium-term Alan J Hewitt / Ian Boutle
8 All backward Euler chemistry schemes None Note that this is only for the “hard-coded” BE schemes. Quite a lot of work would be involved, but good as a longer-term aim. Note that problems for AQUM would need to be addressed first. PROPOSED Long-term Luke Abraham
9 Deprecated UKCA netcdf attribute options UM:#2513 'emission_type', string type attributes no longer recommeneded. Need some time for most new code to adopt these. Still used in AQUM files. DEPRECATED Medium-term Nick Savage AQUM are addressing the files. Have gone from operational jobs, have ticket to remove from rose-stem. LN to document. These have been removed from AQUM.
AQUM work has been done.
10 ASAD families chemistry None Families chemistry has not been used for many years (since at least UM6.1. It is likely that it no longer works if turned on, and it complicates the code making other developments harder DEPRECATED Short-term Luke Abraham
11 Dry deposition 9 PFT option None The 13 PFT option has been adopted for UKESM1.
The 9 PFT option is possibly not being used at all.
Proposed in June 2018.
PROPOSED Long-term Alan J Hewitt
12 Remove explicit C_SPECIES constants and calculate these from M_SPECIES and the mass of air None Will have wide-ranging rose-stem KGO breakages PROPOSED Short-term Luke Abraham
13 Remove temporary logical l_fix_nacl_density
Introduced at UM:#2405
UM:#3490 Requires AMIP testing and a GMED ticket
Could be accepted to GA9
PROPOSED Medium-term Jane Mulcahy See JM GMED action
15 Remove temporary logical l_fix_ukca_impscav
Introduced at UM:#1421
UM:#4145 Approval being sought for GA series (likely GA9)
GMED:#402
PROPOSED Medium-term Alan J Hewitt See JM GMED action
16 Remove temporary logical l_fix_improve_drydep
Introduced at UM:#1250
UM:#3997 Approval being sought for GA series (likely GA9)
GMED:#393
PROPOSED Medium-term Alan J Hewitt See JM GMED action
17 Remove temporary logical l_fix_ukca_h2dd_x
Introduced at UM:#4157
UM:#4245 Approval being sought for GA series (likely GA9)
GMED:#410
PROPOSED Medium-term Alan J Hewitt See JM GMED action
18 Remove temporary logical l_fix_neg_pvol_wat
Introduced at UM:#4383
UM:#4416 Approval being sought for GA series (likely GA9)
GMED:#421
PROPOSED Medium-term Alan J Hewitt
20 Remove MODULEs/SUBROUTINEs/FUNCTIONs
within UKCA not called within the UM:

MODULE asad_emissn_mod and SUBROUTINE asad_emissn
MODULE asad_inemit_mod and SUBROUTINE asad_inemit
UM:#4827 Requires removing additional redundant emission code from ukca_chem_master.F90 vn11.3_remove_asad_emissn_mod DEPRECATED Short-term Alan J Hewitt Should be finished for vn11.4
21 Remove code behind L_use_stratclim from ukca_fastjx_mod
Introduced prior to MOSRS
UM:#4875 This could either be properly included via a namelist or removed from the UM PROPOSED Medium-term Alan J Hewitt LA contact OW about progressing FastJX-RADAER work
22 Remove temporary logical l_fix_ukca_input_meoh_emiss
Introduced at UM:#3031
UM:#4848 Approval being sought for GA series (likely GA9)
GMED:#461
PROPOSED Medium-term Mohit Dalvi


Update on UKCA API redesign

JH has been working on redesigning the UM-UKCA interface to remove the model specific coupling. His proposed design document can be found here:

UKCA Testing Requirements (LA)

It would be helpful to fully document what is expected regarding code changes, e.g. rose-stem, AMIP & short tests, AQUM tests etc.

Initial details have been added here: Testing Requirements for UKCA Code Changes

UM11.5 & UM11.6 Tickets

See here for UM vn11.5 tickets on MOSRS.

See here for UM vn11.6 tickets on MOSRS.

PLEASE REMEMBER TO USE THE UKCA KEYWORD FOR ALL UKCA CHANGES

UM vn11.5 is a CLOSED RELEASE for UKCA changes (except for API changes).

AOB/DNM (LA)

AJH - planned refactoring work to get benefits of OpenMP (removing IF inside DO loops). See changes to ukca_mode_setup.F90.

Date of next meeting (LA)